613226 - release mail notification sends mail for all active release branches anytime any builder finishes

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

I thought this was just on the ChangeNotifier at first but I'm now noticing that I get mail for 4.0b6, 3.6.13, and 3.5.14 whenever a builder for my 3.6.13 staging run finishes.

Comment 1

[Syed Albiz [:salbiz]]

Probably an unforeseen consequence of landing the multi-branch stuff. The MailNotifier hangs onto all builders with category in ['release',]. This doesn't explain why ChangeNotifier is also sending out dup emails for tagging

Comment 2

[Syed Albiz [:salbiz]]

Attachment: filter release builder categories by branch

I was able to stop duplicate emails from MailNotifier altogether by filtering by builder category, could you please confirm that the only dup emails you get are when steps _complete_? I could not reproduce any dup emails from the ChangeNotifiers (i.e. when tagging starts, or signing finishes)

Comment 3

[[e-mail] (:bhearsum)]

Yeah, you're right...only when steps finish. I only get 3.6.13 mail from the ChangeNotifier. Sorry about the confusion!

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 491660 [details] [diff] [review]
filter release builder categories by branch

This seems fine, let's hold off on landing it until after 3.6.13/3.5.16 since it's not critical.

Comment 5

[[e-mail] (:bhearsum)]

Lukas, do you have any input here?

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 491660 [details] [diff] [review]
filter release builder categories by branch

changeset:   1220:ad35199f9125

Comment 7

[[e-mail] (:bhearsum)]

All done here.