613283 - content/canvas/src/WebGLContextGL.cpp:127: warning: 'PRBool InternalFormatHasAlpha(WebGLenum)' defined but not used

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 539771 added the following static helper function to WebGLContextGL.cpp... 

+static PRBool
+InternalFormatHasAlpha(WebGLenum aInternalFormat) {
+    return aInternalFormat == LOCAL_GL_RGBA4 ||
+        aInternalFormat == LOCAL_GL_RGB5_A1;
+}
http://hg.mozilla.org/mozilla-central/diff/941c3d14e14d/content/canvas/src/WebGLContextGL.cpp

... but there are no callers of this method, so we spam this warning:
> WebGLContextGL.cpp:127: warning: 'PRBool InternalFormatHasAlpha(WebGLenum)' defined but not used


Note that this changeset added a method of the same name, with a separate definition, in the .h file:
http://hg.mozilla.org/mozilla-central/diff/941c3d14e14d/content/canvas/src/WebGLContext.h
*That* method has callers (in the .h file), but the one from the .cpp file does not have any callers & should probably be removed.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: trivial fix (remove unused method)

Requesting r+a.  Just reverting the introduction of an unused method. (with an actually-used alternate version declared elsewhere, as noted above -- so I think this was just a stale chunk that wasn't intended to land)

Comment 2

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/d07d0b74d3e2