Closed
Bug 613306
Opened 15 years ago
Closed 15 years ago
fix bufferSubData quickStub
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
People
(Reporter: bjacob, Assigned: bjacob)
Details
Attachments
(2 files, 2 obsolete files)
|
871 bytes,
patch
|
vlad
:
review+
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
|
6.46 KB,
patch
|
vlad
:
review+
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
This makes us pass the array-buffer-view-crash.html WebGL test.
bufferSubData was generating an exception when passed a null argument, preventing that WebGL test from continuing.
In this case, it seems safe to allow to continue, as we're not dereferencing this pointer in the quickstub.
Attachment #491639 -
Flags: review?(vladimir)
|
Assignee | |
Updated•15 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Attachment #491639 -
Flags: review?(vladimir) → review+
|
||
Updated•15 years ago
|
Attachment #491639 -
Flags: approval2.0+
|
|
Assignee | |
Comment 1•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 2•15 years ago
|
||
Oops, I get a crash in js_IsArrayBuffer in this quickstub: turns out that there was a reason why we were checking for null.
However the previous solution was not good, as it made us non-conforming and made us interrupt the script.
New patch coming.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 3•15 years ago
|
||
Here's the patch, it fixes the crash.
|
|
Assignee | |
Comment 4•15 years ago
|
||
Comment on attachment 493302 [details] [diff] [review]
fix bufferSubData quickstub again
ah no, crash still here, will look at it tomorrow.
Attachment #493302 -
Attachment is obsolete: true
Attachment #493302 -
Flags: review?(vladimir)
|
|
Assignee | |
Comment 5•15 years ago
|
||
OK, this time it's working. bufferData needed a similar change too.
The unit test has a probable bug:
http://www.khronos.org/bugzilla/show_bug.cgi?id=386
The patched minefields passes the patched test.
Attachment #493442 -
Flags: review?(vladimir)
|
|
Assignee | |
Comment 6•15 years ago
|
||
Updated following the discussion at
http://www.khronos.org/bugzilla/show_bug.cgi?id=386
Attachment #493442 -
Attachment is obsolete: true
Attachment #493764 -
Flags: review?(vladimir)
Attachment #493442 -
Flags: review?(vladimir)
Comment on attachment 493764 [details] [diff] [review]
fix bufferSubData (and bufferData) again
hmm.. I'm not a huge fan of Buffer[Sub]Data_null, but I guess it's fine; clearer, regardless.
Attachment #493764 -
Flags: review?(vladimir) → review+
|
|
||
Updated•15 years ago
|
Attachment #493764 -
Flags: approval2.0+
|
|
Assignee | |
Comment 8•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•