Closed Bug 613350 Opened 9 years ago Closed 9 years ago

Pass 2 more WebGL draw-tests

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(1 file)

This makes us pass draw-elements-out-of-bounds.html and draw-arrays-out-of-bounds.html, just by moving the check for count==0 a bit up. This is just adjusting to the behavior that the webkit people chose, just a path of least resistance, not really a bugfix, although in the drawArrays case it really makes sense to check that next to the if(!mCurrentProgram) so we group the two NOP paths.
Attachment #491663 - Flags: review?(vladimir)
Comment on attachment 491663 [details] [diff] [review]
pass 2 more draw-tests

heh, I swear we want back and forth on this.. but this is fine :)
Attachment #491663 - Flags: review?(vladimir) → review+
Attachment #491663 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/215657c24079
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → bjacob
You need to log in before you can comment on or make changes to this bug.