Closed Bug 613403 Opened 9 years ago Closed 9 years ago

Fix existing tests to work with tab-modal prompt changes

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b8

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file)

Attached patch Patch v.1Splinter Review
Bug 59314 is adding support for tab-modal prompts. 2 tests currently interact with prompts by listening for |domwindowopened| notifications. Since tab-modal prompts don't open windows, these tests break.

I've converted these two tests to use the notifications fired by nsIPrompts (common-dialog-loaded and tabmodal-dialog-loaded). They will work with current trunk (pre-59314), as well as once bug 59314 lands.

[Currently pushing this to try.]
Assignee: nobody → dolske
Comment on attachment 491737 [details] [diff] [review]
Patch v.1

r=me on the editor test, as long as you get a green run on try.
Attachment #491737 - Flags: review+
Try run was green. Since the other test change (browser_sidebarpanels_click.js) change is fairly trivial, will land this shortly.
Pushed http://hg.mozilla.org/mozilla-central/rev/bbc4273845eb
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
You need to log in before you can comment on or make changes to this bug.