Closed Bug 613425 Opened 9 years ago Closed 9 years ago

dehydra: unbreak static-checking builds

Categories

(Firefox Build System :: Source Code Analysis, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ehren.m, Assigned: ehren.m)

References

Details

Attachments

(2 files)

Attached patch patchSplinter Review
A couple of misc fixes for annoying front end trees and a typo in esp.
Also, trying to deal with bug 591875, I found out that enabling methodjit completely bypasses the problem even though it can still be reproduced with just the tracer.

btw rough times for the dehydra/treehydra testsuite on my machine
TM: 6s
JM: 6.6s
JM+TM 6.3s
Attachment #491764 - Flags: review?(tglek)
minor problem with static-initializer analysis
Attachment #491766 - Flags: review?(tglek)
Attachment #491766 - Flags: review?(tglek) → review+
http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/c13265a55f54

mozilla-central patch needs check-in
Keywords: checkin-needed
Comment on attachment 491766 [details] [diff] [review]
mozilla-central patch

>From: Ehren Metcalfe <ehren.m@gmail.com>
>Bug 613425 - static checking suite: fix static initializer warnings with COMPONENT_REFs r=taras a=test-only [DONTBUILD]
>
>diff --git a/xpcom/analysis/static-init.js b/xpcom/analysis/static-init.js
>--- a/xpcom/analysis/static-init.js
>+++ b/xpcom/analysis/static-init.js
>@@ -45,10 +45,10 @@ function constructorArg(call) {
>   return arg.tree_code() == ADDR_EXPR ? TREE_OPERAND(arg, 0) : arg;
> }
> 
> function pretty_func(fn) {
>   return rfunc_string(rectify_function_decl(fn));
> }
> 
> function pretty_var(v) {
>-  return type_string(TREE_TYPE(v)) + " " + decl_name_string(v);
>+  return type_string(TREE_TYPE(v)) + " " + expr_display(v);
> }
mozilla-central patch checked in:

http://hg.mozilla.org/mozilla-central/rev/7d09a3dfbfcb
Keywords: checkin-needed
thanks Ehsan!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #491764 - Flags: review?(tglek) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.