613425 - dehydra: unbreak static-checking builds

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ehren Metcalfe]

Attachment: patch

A couple of misc fixes for annoying front end trees and a typo in esp.
Also, trying to deal with bug 591875, I found out that enabling methodjit completely bypasses the problem even though it can still be reproduced with just the tracer.

btw rough times for the dehydra/treehydra testsuite on my machine
TM: 6s
JM: 6.6s
JM+TM 6.3s

Comment 1

[Ehren Metcalfe]

Attachment: mozilla-central patch

minor problem with static-initializer analysis

Comment 2

[Ehren Metcalfe]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/c13265a55f54

mozilla-central patch needs check-in

Comment 3

[Ehren Metcalfe]

Comment on attachment 491766 [details] [diff] [review]
mozilla-central patch

>From: Ehren Metcalfe <[e-mail]>
>Bug 613425 - static checking suite: fix static initializer warnings with COMPONENT_REFs r=taras a=test-only [DONTBUILD]
>
>diff --git a/xpcom/analysis/static-init.js b/xpcom/analysis/static-init.js
>--- a/xpcom/analysis/static-init.js
>+++ b/xpcom/analysis/static-init.js
>@@ -45,10 +45,10 @@ function constructorArg(call) {
>   return arg.tree_code() == ADDR_EXPR ? TREE_OPERAND(arg, 0) : arg;
> }
> 
> function pretty_func(fn) {
>   return rfunc_string(rectify_function_decl(fn));
> }
> 
> function pretty_var(v) {
>-  return type_string(TREE_TYPE(v)) + " " + decl_name_string(v);
>+  return type_string(TREE_TYPE(v)) + " " + expr_display(v);
> }

Comment 4

[(no longer active)]

mozilla-central patch checked in:

http://hg.mozilla.org/mozilla-central/rev/7d09a3dfbfcb

Comment 5

[Ehren Metcalfe]

thanks Ehsan!