If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

parseFloat("infinity") should return NaN

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 1 obsolete attachment)

There's some redundant code in dtoa.c that causes this; will attach a patch to remove it.
Created attachment 491836 [details] [diff] [review]
Patch

This patch passes tests. An alternative approach is to #define NO_INFNAN_CHECK, but I noticed that previous revisions also removed code from dtoa.c so I did that too.
Assignee: general → jandemooij
Status: NEW → ASSIGNED
Attachment #491836 - Flags: review?(jwalden+bmo)
Created attachment 491838 [details] [diff] [review]
Patch

Forgot to add the right bug number to the test.
Attachment #491836 - Attachment is obsolete: true
Attachment #491838 - Flags: review?(jwalden+bmo)
Attachment #491836 - Flags: review?(jwalden+bmo)
Comment on attachment 491838 [details] [diff] [review]
Patch

Seems reasonable.
Attachment #491838 - Flags: review?(jwalden+bmo) → review+
http://hg.mozilla.org/tracemonkey/rev/1b24f8e54d1b
Whiteboard: fixed-in-tracemonkey

Comment 5

7 years ago
http://hg.mozilla.org/mozilla-central/rev/1b24f8e54d1b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.