Closed
Bug 613565
Opened 14 years ago
Closed 14 years ago
checkCpoolOperand() is embarassingly overkill, and abuses atom tag enums
Categories
(Tamarin Graveyard :: Verifier, defect)
Tamarin Graveyard
Verifier
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edwsmith, Assigned: edwsmith)
References
Details
Attachments
(1 file)
|
4.14 KB,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
* At call sites, the value passed in is always constant.
* The values are Atom tag values, but have nothing to do with Atom
* switch is unnecessary, Assert is dead code
* moreover, at least one call site is just cut+pasted from the body.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → edwsmith
Attachment #491918 -
Flags: review?(stejohns)
|
||
Updated•14 years ago
|
Attachment #491918 -
Flags: review?(stejohns) → review+
|
||
Comment 2•14 years ago
|
||
changeset: 5603:e1c682fc8fa2
user: Edwin Smith <edwsmith@adobe.com>
summary: Bug 613565 - checkCpoolOperand() is embarassingly overkill, and abuses atom tag enums (r=stejohns+)
http://hg.mozilla.org/tamarin-redux/rev/e1c682fc8fa2
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•