Closed
Bug 613643
Opened 12 years ago
Closed 12 years ago
nsBaseChannel.h:301:12: warning: ‘nsBaseChannel::mStatus’ will be initialized after ... ‘PRPackedBool nsBaseChannel::mQueriedProgressSink’ ... when initialized here (nsBaseChannel.cpp:88)
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
937 bytes,
patch
|
azakai
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/rev/e63ac78f181e reordered nsBaseChannel's member data in the class definition, but didn't reorder the init list, triggering the following build warning spam: > netwerk/base/src/nsBaseChannel.h: In constructor ‘nsBaseChannel::nsBaseChannel()’: > netwerk/base/src/nsBaseChannel.h:301:12: warning: ‘nsBaseChannel::mStatus’ will be initialized after > netwerk/base/src/nsBaseChannel.h:290:16: warning: ‘PRPackedBool nsBaseChannel::mQueriedProgressSink’ > netwerk/base/src/nsBaseChannel.cpp:88:1: warning: when initialized here
Assignee | ||
Comment 1•12 years ago
|
||
Here's the fix. Verified locally that it fixes the build warning.
Assignee | ||
Updated•12 years ago
|
Attachment #491977 -
Flags: approval2.0?
Updated•12 years ago
|
Attachment #491977 -
Flags: review?(azakai) → review+
Comment 2•12 years ago
|
||
Comment on attachment 491977 [details] [diff] [review] trivial fix (reorder init list to match .h file) a=rs
Attachment #491977 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 3•12 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/356c5d923a13
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•