Closed Bug 613643 Opened 10 years ago Closed 10 years ago
Base Channel .h:301:12: warning: ‘ns Base Channel::m Status’ will be initialized after ... ‘PRPacked Bool ns Base Channel::m Queried Progress Sink’ ... when initialized here (ns Base Channel .cpp:88)
http://hg.mozilla.org/mozilla-central/rev/e63ac78f181e reordered nsBaseChannel's member data in the class definition, but didn't reorder the init list, triggering the following build warning spam: > netwerk/base/src/nsBaseChannel.h: In constructor ‘nsBaseChannel::nsBaseChannel()’: > netwerk/base/src/nsBaseChannel.h:301:12: warning: ‘nsBaseChannel::mStatus’ will be initialized after > netwerk/base/src/nsBaseChannel.h:290:16: warning: ‘PRPackedBool nsBaseChannel::mQueriedProgressSink’ > netwerk/base/src/nsBaseChannel.cpp:88:1: warning: when initialized here
Here's the fix. Verified locally that it fixes the build warning.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #491977 - Flags: review?(azakai)
Attachment #491977 - Flags: approval2.0?
Comment on attachment 491977 [details] [diff] [review] trivial fix (reorder init list to match .h file) a=rs
Attachment #491977 - Flags: approval2.0? → approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.