Closed
Bug 613679
Opened 14 years ago
Closed 14 years ago
pluginreg.dat rewritten on plugins list construction, even if there are no changes
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(blocking2.0 betaN+)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: sgreenlay, Assigned: sgreenlay)
Details
Attachments
(2 files)
|
672 bytes,
patch
|
jaas
:
review+
jaas
:
approval2.0+
|
Details | Diff | Splinter Review |
|
1.21 KB,
patch
|
Details | Diff | Splinter Review |
In http://hg.mozilla.org/mozilla-central/rev/ced813e0209d we moved *aPluginsChanged = PR_TRUE; In it's new location, it is marked TRUE every time a plugin tag is added. This means that when we initially build the plugins list, it is being marked as having changed, even if there is no difference from pluginreg.dat. aPluginsChanged is used to determine when to rewrite pluginreg.dat, so we are rewriting it every time we create the plugin list.
|
Assignee | |
Comment 1•14 years ago
|
||
blocking2.0: --- → ?
Comment on attachment 492010 [details] [diff] [review] PluginReg Rewrite Fix (v1.0) Use braces with the if statement.
Attachment #492010 -
Flags: review?(joshmoz)
Attachment #492010 -
Flags: review+
Attachment #492010 -
Flags: approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/076f5ea1f94a
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•