Closed Bug 613679 Opened 10 years ago Closed 10 years ago

pluginreg.dat rewritten on plugins list construction, even if there are no changes

Categories

(Core :: Plug-ins, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: sgreenlay, Assigned: sgreenlay)

Details

Attachments

(2 files)

In http://hg.mozilla.org/mozilla-central/rev/ced813e0209d we moved *aPluginsChanged = PR_TRUE; In it's new location, it is marked TRUE every time a plugin tag is added. This means that when we initially build the plugins list, it is being marked as having changed, even if there is no difference from pluginreg.dat. aPluginsChanged is used to determine when to rewrite pluginreg.dat, so we are rewriting it every time we create the plugin list.
Assignee: nobody → sgreenlay
Status: NEW → ASSIGNED
Attachment #492010 - Flags: review?(joshmoz)
Comment on attachment 492010 [details] [diff] [review]
PluginReg Rewrite Fix (v1.0)

Use braces with the if statement.
Attachment #492010 - Flags: review?(joshmoz)
Attachment #492010 - Flags: review+
Attachment #492010 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/076f5ea1f94a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Duplicate of this bug: 614423
blocking2.0: ? → betaN+
You need to log in before you can comment on or make changes to this bug.