Closed Bug 613810 Opened 9 years ago Closed 9 years ago

Undo(ctrl+z) does not work continuously after committing IME

Categories

(Core :: DOM: Editor, defect, major)

x86
All
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla2.0b8
Tracking Status
blocking2.0 --- final+

People

(Reporter: alice0775, Assigned: masayuki)

References

()

Details

(Keywords: inputmethod, regression)

Attachments

(1 file, 1 obsolete file)

Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101120 Firefox/4.0b8pre ID:20101120044537

Undo(ctrl+z) does not work continuously.

*This does not happen on Firefox3.6.13pre.
*This happens on WindowsXP+MS-IME2002 and Windows7+ATOK2006/Microsoft IME.(I did not try other IME)
*This happens on ubuntu8.04+SCIM
*This happens with not only textarea/input, but also XUL/textbox such as searchBar.


Reproducible: Always

Steps to Reproduce:
1. Start minefield with new profile
2. Open any page that including textarea/input tag ( data:text/html;charset=utf-8,<textarea><%2Ftextarea> )
3. Click and focus textarea/input
4. IME on
5. Input something and commit
6. Input something and commit
7. Undo (ctrl+z)----OK, Step 6 was undone
8. Undo (ctrl+z)----NG, nothing happens

Actual Results:
 Nothing happens
 Though "Undo" context menu of the textarea is active state. 

Expected Results:
 Step5 should be undone

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/b66b7330b505
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100408 Minefield/3.7a5pre ID:20100409223307
Fails:
http://hg.mozilla.org/mozilla-central/rev/fccdd48b82ae
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100410 Minefield/3.7a5pre ID:20100410093733
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b66b7330b505&tochange=fccdd48b82ae
Candidate:
bd0b0915864b	Masayuki Nakano — Bug 543398 Drop nsTextEventReply and nsIPrivateCompositionEvent r=smaug, sr=roc
blocking2.0: --- → ?
Attached patch Patch v1.0 (obsolete) — Splinter Review
Nice catch! I'll create automated tests for this. Thank you for your test and report.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Blocks: 613807
Attachment #492184 - Attachment is obsolete: true
Attachment #492944 - Flags: review?(ehsan)
Comment on attachment 492944 [details] [diff] [review]
Patch v1.0 with test

Looks great!  (And thanks for teaching me how to test IME composition by reading this patch!)

The only thing that I don't like about this patch is calling undo on the editor object manually.  Please replace them all with:

synthesizeKey("Z", {accelKey: true});

r=me with that.
Attachment #492944 - Flags: review?(ehsan) → review+
I addressed my own nits, and landed the patch:

http://hg.mozilla.org/mozilla-central/rev/435a1bae2cea
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: mozilla2.0 → mozilla2.0b8
Thank you for updating and landing it.
You need to log in before you can comment on or make changes to this bug.