Port |Bug 469880. Support a libnotify-based implementation of nsIAlertsService for GTK.| to comm-central

RESOLVED WONTFIX

Status

defect
RESOLVED WONTFIX
9 years ago
7 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Trunk
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

9 years ago
Posted patch v1 (obsolete) — Splinter Review
This bug ports:

Bug 469880. Support a libnotify-based implementation of nsIAlertsService for GTK.

For c-c configure.in sync.
Attachment #492132 - Flags: review?(kairo)
Assignee

Updated

9 years ago
Attachment #492132 - Attachment is obsolete: true
Attachment #492132 - Flags: review?(kairo)
Assignee

Comment 1

9 years ago
Posted patch v2Splinter Review
Actually port it to current, also ports relevant [to libnotify] parts of:

* Bug 526451 (http://hg.mozilla.org/mozilla-central/rev/0c9a366b7e5d)
* Bug 569261 (http://hg.mozilla.org/mozilla-central/rev/ae5e2cf51919)
Attachment #492135 - Flags: review?(kairo)

Comment 2

9 years ago
Comment on attachment 492135 [details] [diff] [review]
v2

I think we should not add anything to the c-c configure unless we have any cases of anything in c-c actually using it, and we should actually remove anything from the build system that is not used by actual c-c code.
Attachment #492135 - Flags: review?(kairo) → review-
OS: Windows XP → Linux
Version: unspecified → Trunk
Assignee

Comment 3

9 years ago
Wontfix per r- of the port.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
(In reply to Justin Wood (:Callek) from comment #1)
> * Bug 526451 (http://hg.mozilla.org/mozilla-central/rev/0c9a366b7e5d)

Ftr, that part was eventually ported in bug 545343.
Depends on: 545343
Summary: Port |Bug 469880. Support a libnotify-based implementation of nsIAlertsService for GTK.| to c-c → Port |Bug 469880. Support a libnotify-based implementation of nsIAlertsService for GTK.| to comm-central
You need to log in before you can comment on or make changes to this bug.