613943 - [@ nsWindow::DoPaint] crashes when trying to access MWindow::orientationAngle

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Tatiana Meshkova (:tatiana)]

Attachment: MWindow::orientationAngle.bt

crash is reproduced with embedding test (pure Qt app)

Comment 1

[Tatiana Meshkova (:tatiana)]

Attachment: patch

MApplication::activeWindow() static method works correctly now, no crashes for pure Qt apps anymore
so, it's ok to rely on it.

Comment 2

[Oleg Romashin (:romaxa)]

Comment on attachment 492308 [details] [diff] [review]
patch

Hmm... previously it was so that if Meego touch not initialized and you call any meegotouch functionality it will abort inside meegotouch.


This seems from another bug.
- NS_ASSERTION(PIXMAN_VERSION < PIXMAN_VERSION_ENCODE(0, 21, 2) && angle, "Old pixman and rotate transform, it is going to be slow");
+ NS_ASSERTION(PIXMAN_VERSION > PIXMAN_VERSION_ENCODE(0, 21, 2) || !angle, "Old pixman and rotate transform, it is going to be slow");

613853

could you make patch on top of patch from bug 613853?

Comment 3

[Tatiana Meshkova (:tatiana)]

Attachment: patch v2

I don't know where do they move MComponentData initialization, but activeWindow() doesn't crash with "-style motif" even

Comment 4

[Oleg Romashin (:romaxa)]

Comment on attachment 492313 [details] [diff] [review]
patch v2

yeah, we can call MApplication::activeWindow(); and don't crash now

Comment 5

[timeless]

while you're here, could you please spell MeeGo correctly?

Comment 6

[Doug Turner (:dougt)]

okay

Comment 7

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/ebbcdbb4bef9