614074 - release tag builder got kicked off wrongly

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

We had this build today get kicked off by what looked like a check-in:
http://production-master01.build.mozilla.org:8010/builders/release-mozilla-central-tag/builds/0

The reason says "scheduler", so I'm not sure which Scheduler that is...but there's a blamelist.

Comment 1

[[e-mail] (:bhearsum)]

J'accuse https://bugzilla.mozilla.org/show_bug.cgi?id=526495

Comment 2

[Syed Albiz [:salbiz]]

Attachment: split DONTBUILD functionality into overrideHgPoller [tested]

Tested this on staging, with the following steps:

/tools/buildbot-0.8.2/bin/buildbot sendchange --master localhost:9011 --user woof --branch users/stage-ffxbld/mozilla-1.9.2 -l "http://hg.mozilla.org/" foo
(No builds started due to hgUrl present in revlink)

/tools/buildbot-0.8.2/bin/buildbot sendchange --master localhost:9011 --user woof --branch users/stage-ffxbld/mozilla-1.9.2 -l "http://hg.mozilla.org/" -c 'DONTBUILD' foo
(No builds started due to hgUrl present in revlink)

/tools/buildbot-0.8.2/bin/buildbot sendchange --master localhost:9011 --user woof --branch users/stage-ffxbld/mozilla-1.9.2 -l " " foo
(release builder started as normal)

/tools/buildbot-0.8.2/bin/buildbot sendchange --master localhost:9011 --user woof --branch releases/mozilla-1.9.2 -l "http://hg.mozilla.org/" foo
(mozilla-1.9.2 regular builds started as per normal)

/tools/buildbot-0.8.2/bin/buildbot sendchange --master localhost:9011 --user woof --branch releases/mozilla-1.9.2 -l "http://hg.mozilla.org/" -c 'DONTBUILD' foo
(no builds started)

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 492733 [details] [diff] [review]
split DONTBUILD functionality into overrideHgPoller [tested]

Looks good!  Can we pick a different name for overrideHgPoller though?  That doesn't really tell me what it's doing.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 492733 [details] [diff] [review]
split DONTBUILD functionality into overrideHgPoller [tested]

Looks good to me, too. I'd call it 'shouldBuild' or something similar though.

Comment 5

[Syed Albiz [:salbiz]]

Attachment: rename to shouldBuild, add docstring

Done, added a docstring as well to make pylint happy(-ier) and explain what the string check actually does.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 492846 [details] [diff] [review]
rename to shouldBuild, add docstring

changeset:   1214:c49ec558ff2d

Comment 7

[Rail Aliiev [:rail]]

While trying to start a staging release by both sendchange and release_sanity.py, I've got the following exception and no build was triggered:

if hgUrl in change.revlink or change.comments.find(hgUrl) > -1:
        exceptions.TypeError: argument of type 'NoneType' is not iterable


As as temporary solution I've changed the line above to:
if (change.revlink and hgUrl in change.revlink) or change.comments.find(hgUrl) > -1:


2010-12-01 02:30:56-0800 [-] Unhandled Error
        Traceback (most recent call last):
          File "/tools/python-2.6.5/lib/python2.6/threading.py", line 504, in __bootstrap
            self.__bootstrap_inner()
          File "/tools/python-2.6.5/lib/python2.6/threading.py", line 532, in __bootstrap_inner
            self.run()
          File "/tools/python-2.6.5/lib/python2.6/threading.py", line 484, in run
            self.__target(*self.__args, **self.__kwargs)
        --- <exception caught here> ---
          File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/Twisted-10.1.0-py2.6-linux-i686.egg/twisted/python/threadpool.py", line 
207, in _worker
            result = context.call(ctx, function, *args, **kwargs)
          File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/Twisted-10.1.0-py2.6-linux-i686.egg/twisted/python/context.py", line 59,
 in callWithContext
            return self.currentContext().callWithContext(ctx, func, *args, **kw)
          File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/Twisted-10.1.0-py2.6-linux-i686.egg/twisted/python/context.py", line 37,
 in callWithContext
            return func(*args,**kw)
          File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/Twisted-10.1.0-py2.6-linux-i686.egg/twisted/enterprise/adbapi.py", line 
429, in _runInteraction
            result = interaction(trans, *args, **kw)
          File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/buildbot-0.8.2-py2.6.egg/buildbot/schedulers/base.py", line 146, in clas
sify_changes
            important = self.fileIsImportant(c)
          File "/builds/buildbot/rail/buildbotcustom/process/release.py", line 190, in <lambda>
            branchConfig['hgurl'])
          File "/builds/buildbot/rail/buildbotcustom/misc.py", line 116, in isHgPollerTriggered
            if hgUrl in change.revlink or change.comments.find(hgUrl) > -1:
        exceptions.TypeError: argument of type 'NoneType' is not iterable

Comment 8

[[e-mail] (:bhearsum)]

Removing old needs-reconfig+ flag.

Comment 9

[Rail Aliiev [:rail]]

Attachment: check revlink

The patch should fix the problem

Comment 10

[[e-mail] (:bhearsum)]

Planning to do a reconfig with this tomorrow morning.

Comment 11

[[e-mail] (:bhearsum)]

Masters have been updated.