change cfx options based on usage expectations

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: myk, Assigned: adw)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Some options with single-letter shortcuts are not expected to be used often enough that it's worth reserving a scarce single-letter shortcut for them, and we should remove those shortcuts.  Others with upper-case shortcuts are expected to be used often enough that it's worth providing them with an easiest-to-use lower-case shortcut.  And one option's name should be simpler and clearer.

Shortcuts to remove:
  -p for --pkgdir
  -k for --extra-packages
  -t for --templatedir
  -r for --use-server (make sure to update "cfx develop" help text accordingly)
  -u for --update-url
  -l for --update-link
  -d for --dep-tests
  -x for --times

Shortcuts to change:
  -P to -p for --profiledir
  -F to -f for --filter

Options to rename:
  --dep-tests to --dependencies
(Assignee)

Updated

7 years ago
Assignee: nobody → adw
Status: NEW → ASSIGNED
Summary: change options based on usage expectations → change cfx options based on usage expectations
(Assignee)

Comment 1

7 years ago
Created attachment 492868 [details] [diff] [review]
patch

Changing --filter's shorthand from -F to -F required removing --logfile's -f shorthand.
Attachment #492868 - Flags: review?(avarma)
(Assignee)

Comment 2

7 years ago
(In reply to comment #1)
> Changing --filter's shorthand from -F to -F required removing --logfile's -f
> shorthand.

From -F to -f I mean, gosh.
(Reporter)

Comment 3

7 years ago
(In reply to comment #1)
> Changing --filter's shorthand from -F to -F required removing --logfile's -f
> shorthand.

Note bug 614128, which includes removal of the --logfile option!

Comment 4

7 years ago
Comment on attachment 492868 [details] [diff] [review]
patch

Looks great, thanks! Pushed:

https://github.com/mozilla/addon-sdk/commit/80f0e68d29a313304a29c28d1c5dcaf67b004b4c
Attachment #492868 - Flags: review?(avarma) → review+

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.