Closed Bug 614145 Opened 9 years ago Closed 9 years ago

Fast-path null return values in quickstubs

Categories

(Core :: XPConnect, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(1 file)

We're doing it in domclassinfo; no reason not to do it here too.  Would avoid some expensive calls!
Applies on top of bug 614138.
Depends on: 614138
Whiteboard: [need review]
Blocks: domperf
Keywords: perf
Attachment #492555 - Flags: review?(peterv)
Comment on attachment 492555 [details] [diff] [review]
Fast-path null in quickstub return values.

Hmm, ok. I thought null values were rare here but I guess it doesn't hurt too much for the (common) non-null case. (And we really should switch to %(name) formatting to avoid repeating the same arguments over and over :-))
Attachment #492555 - Flags: review?(peterv) → review+
Attachment #492555 - Flags: approval2.0?
Whiteboard: [need review] → [need approval]
Whiteboard: [need approval] → [need gk2 ship]
Attachment #492555 - Flags: approval2.0? → approval2.0-
Pushed http://hg.mozilla.org/mozilla-central/rev/470b68779bf1
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [need gk2 ship]
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.