614181 - Remove app.update.timer preference and add app.update.timerMinimumDelay preference

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Robert Strong (they/them - no direct email)]

Bug 604804 removed the app.update.timer preference (the timer delay) and added a app.update.timerMinimumDelay preference (the minimum timer delay with a default of 120 seconds and a minimum of 60 seconds). The timer now staggers calling each nsITimerCallback, varies the delay between firing based on whether there are timers that were skipped, and schedules the next firing based on the shortest next update time out of each nsITimerCallback.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 492784 [details] [diff] [review]
patch

Dão, perhaps you have time to review this?

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 492784 [details] [diff] [review]
patch

mobile/app/mobile.js sets app.update.timer as well.

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to comment #3)
> Comment on attachment 492784 [details] [diff] [review]
> patch
> 
> mobile/app/mobile.js sets app.update.timer as well.
Yes... there were a couple of the mobile team cc'd to the bug that obsoleted the pref and I had hoped one of them would have done it per bug 604804 comment #21. :(

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://tinyurl.com/48zvtw6

Comment 6

[Daniel C]

(In reply to comment #5)
> Pushed to mozilla-central
> http://tinyurl.com/48zvtw6

I think that should be: http://hg.mozilla.org/mozilla-central/rev/55c53b4c28af

Comment 7

[George Carstoiu]

Verified on Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110504 Firefox/6.0a1

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

This preference could be in use by some extensions. Flagging for dev doc.