Closed Bug 614181 Opened 9 years ago Closed 9 years ago

Remove app.update.timer preference and add app.update.timerMinimumDelay preference

Categories

(Firefox :: Preferences, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 6

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

Bug 604804 removed the app.update.timer preference (the timer delay) and added a app.update.timerMinimumDelay preference (the minimum timer delay with a default of 120 seconds and a minimum of 60 seconds). The timer now staggers calling each nsITimerCallback, varies the delay between firing based on whether there are timers that were skipped, and schedules the next firing based on the shortest next update time out of each nsITimerCallback.
Attached patch patchSplinter Review
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #492784 - Flags: review?(gavin.sharp)
Comment on attachment 492784 [details] [diff] [review]
patch

Dão, perhaps you have time to review this?
Attachment #492784 - Flags: review?(dao)
Comment on attachment 492784 [details] [diff] [review]
patch

mobile/app/mobile.js sets app.update.timer as well.
Attachment #492784 - Flags: review?(dao) → review+
Attachment #492784 - Flags: review?(gavin.sharp)
(In reply to comment #3)
> Comment on attachment 492784 [details] [diff] [review]
> patch
> 
> mobile/app/mobile.js sets app.update.timer as well.
Yes... there were a couple of the mobile team cc'd to the bug that obsoleted the pref and I had hoped one of them would have done it per bug 604804 comment #21. :(
Pushed to mozilla-central
http://tinyurl.com/48zvtw6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
(In reply to comment #5)
> Pushed to mozilla-central
> http://tinyurl.com/48zvtw6

I think that should be: http://hg.mozilla.org/mozilla-central/rev/55c53b4c28af
Verified on Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110504 Firefox/6.0a1
Status: RESOLVED → VERIFIED
This preference could be in use by some extensions. Flagging for dev doc.
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.