614289 - Regression: Awesomebar suggestions do not update while typing [HWKB]

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Open the hardware keyboard.
2. Tap in the awesomebar and start typing.

Expected results: Awesomescreen results update as you type.

Actual results: Awesomescreen results update only for the first character typed, or whenever you press backspace.

Tested on local trunk Android build.

Comment 1

[Matt Brubeck (:mbrubeck)]

The "keydown" events are not sent to Gecko, because mKeyListener.onKeyDown returns "true" in GeckoApp::onKeyDown.

Comment 2

[Michael Wu [:mwu]]

(In reply to comment #1)
> The "keydown" events are not sent to Gecko, because mKeyListener.onKeyDown
> returns "true" in GeckoApp::onKeyDown.

Of course, keydown events aren't the only thing that can trigger awesomebar updating. After all, almost no key events are sent when typing with many soft keyboards. The difference is that the text events during softkb composition are sent during composition, while the text events sent through the hardkb listener are sent without composition. Wonder if that makes the difference. Maybe jchen knows.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: WIP

mwu suggested starting and stopping coposition to force an update.  Here's an implementation of that suggestion.  It fixes this bug, but I'm not sure if it's the correct way to do it.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Here's a better patch, with much help from jchen.  Makes sure that the text event happens between composition begin/end events.

Comment 5

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/a4af96fd1ce2

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101129 Namoroka/4.0b8pre Fennec/4.0b3pre