Closed
Bug 614445
Opened 15 years ago
Closed 14 years ago
delete used to free memory allocated by operator new[] in Ogg backend
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: cajbir, Assigned: cajbir)
Details
Attachments
(1 file, 1 obsolete file)
|
1.07 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
Came across this while looking for something else. Raising bug so I don't forget.
In nsOggCodecState.cpp:
void nsPageQueue::Append(ogg_page* aPage) {
...
p->header = new unsigned char[p->header_len + p->body_len];
...
}
PRBool nsOggCodecState::PageInFromBuffer() {
...
ogg_page *p = mBuffer.PeekFront();
...
125 delete p->header;
...
}
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → chris.double
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #514694 -
Flags: review?(chris)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 514694 [details] [diff] [review]
Fix
We probably need the same for OggPageDeallocator in nsOggCoodecState.h as well?
|
|
Assignee | |
Comment 3•14 years ago
|
||
Change delete in nsOggCodecState.h as well.
Attachment #514694 -
Attachment is obsolete: true
Attachment #514717 -
Flags: review?(chris)
Attachment #514694 -
Flags: review?(chris)
|
|
||
Updated•14 years ago
|
Attachment #514717 -
Flags: review?(chris) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs landing post ff4]
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing post ff4]
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•