Closed Bug 614445 Opened 9 years ago Closed 9 years ago

delete used to free memory allocated by operator new[] in Ogg backend

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: cajbir, Assigned: cajbir)

Details

Attachments

(1 file, 1 obsolete file)

Came across this while looking for something else. Raising bug so I don't forget.

In nsOggCodecState.cpp:

void nsPageQueue::Append(ogg_page* aPage) {
  ...
  p->header = new unsigned char[p->header_len + p->body_len];
  ...
}

PRBool nsOggCodecState::PageInFromBuffer() {
   ...
   ogg_page *p = mBuffer.PeekFront();
   ...
   125   delete p->header;
   ...
}
Assignee: nobody → chris.double
Attached patch Fix (obsolete) — Splinter Review
Attachment #514694 - Flags: review?(chris)
Comment on attachment 514694 [details] [diff] [review]
Fix

We probably need the same for OggPageDeallocator in nsOggCoodecState.h as well?
Attached patch FixSplinter Review
Change delete in nsOggCodecState.h as well.
Attachment #514694 - Attachment is obsolete: true
Attachment #514717 - Flags: review?(chris)
Attachment #514694 - Flags: review?(chris)
Attachment #514717 - Flags: review?(chris) → review+
Whiteboard: [needs landing post ff4]
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/0a588ac7cda5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing post ff4]
Target Milestone: --- → mozilla2.2
Can someone confirm if this is fixed?
You need to log in before you can comment on or make changes to this bug.