If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

delete used to free memory allocated by operator new[] in Ogg backend

RESOLVED FIXED in mozilla5

Status

()

Core
Audio/Video
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: cajbir, Assigned: cajbir)

Tracking

Trunk
mozilla5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Fix
1.07 KB, patch
cpearce
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Came across this while looking for something else. Raising bug so I don't forget.

In nsOggCodecState.cpp:

void nsPageQueue::Append(ogg_page* aPage) {
  ...
  p->header = new unsigned char[p->header_len + p->body_len];
  ...
}

PRBool nsOggCodecState::PageInFromBuffer() {
   ...
   ogg_page *p = mBuffer.PeekFront();
   ...
   125   delete p->header;
   ...
}
(Assignee)

Updated

7 years ago
Assignee: nobody → chris.double
(Assignee)

Comment 1

7 years ago
Created attachment 514694 [details] [diff] [review]
Fix
Attachment #514694 - Flags: review?(chris)
Comment on attachment 514694 [details] [diff] [review]
Fix

We probably need the same for OggPageDeallocator in nsOggCoodecState.h as well?
(Assignee)

Comment 3

7 years ago
Created attachment 514717 [details] [diff] [review]
Fix

Change delete in nsOggCodecState.h as well.
Attachment #514694 - Attachment is obsolete: true
Attachment #514717 - Flags: review?(chris)
Attachment #514694 - Flags: review?(chris)
Attachment #514717 - Flags: review?(chris) → review+
(Assignee)

Updated

7 years ago
Whiteboard: [needs landing post ff4]
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

7 years ago
http://hg.mozilla.org/mozilla-central/rev/0a588ac7cda5
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing post ff4]
Target Milestone: --- → mozilla2.2
Can someone confirm if this is fixed?
You need to log in before you can comment on or make changes to this bug.