614540 - Form Helper should not close when data are load in the background

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Steps to reproduce:
 * Go to Advance search bugzilla.mozilla.org
 * Click on the combobox next to "Whiteboard"
 * Click on the down button in form assistant

Actual result:
 * The Form Assistant dissapear

Expected result:
 * The form assistant stays open


The patch also include a fix to prevent entering the "focus" handler of forms.js when manually focusing an element

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 492982 [details] [diff] [review]
Patch

URLChanged is used by FindHelperUI, which should be fine, and IdentityPanel, which seems like this change shouldn't hurt.

However, I don't understand why moving the event matters. I assumed that you should not fire the event for background tabs, but both locations (old and new) fire the event even when the tab is not the selected tab.

Tell me why this works.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Comment on attachment 492982 [details] [diff] [review]
> Patch
> 
> URLChanged is used by FindHelperUI, which should be fine, and IdentityPanel,
> which seems like this change shouldn't hurt.
> 
> However, I don't understand why moving the event matters. I assumed that you
> should not fire the event for background tabs, but both locations (old and new)
> fire the event even when the tab is not the selected tab.
> 
> Tell me why this works.

I've just moved the event from _networkStart to onLocationChange otherwise loading some data in the background (I thought of a XMLHTTPRequest as example) fire network start and reset the Form Assistant. This is what happens on bugzilla.

Also I don't think networkStart is fired for local page:
 * try to load a page that does not exist: file:///tmp/void.html
 * type data:text/html,<input> in the urlbar and load the page
 * click in the input field and see the form helper
 * show the right sidebar and click on the back button
 
result: the "page not found" is shown and the form helper is _visible_.
 
Though I assume i should look at the background tab can close the form helper issue you mentionned

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch still move the event dispatching but also take care on which browser the event is generated to avoid hiding the findhelper, formhelper, identity-popup if unnecessary.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Wait until we branch for beta 3 to land

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/a4d03b8b42c5

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101210 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101210 Namoroka/4.0b8pre Fennec/4.0b3pre

Comment 8

[Dão Gottwald [:dao]]

bugspam