Closed
Bug 614541
Opened 14 years ago
Closed 14 years ago
Supply username to verify bump commit in release updates factory
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
Details
Attachments
(1 file)
960 bytes,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
Since the update to a newer Mercurial on Linux slaves, a commit without a user name fails. Even if we can circumvent this by specifying a user name in a ~/.hgrc, it's better to be safe and also supply one directly in the one command we have in our release process that doesn't have it - the verify config bump commit in the updates factory.
I have a patch locally.
Assignee | ||
Comment 1•14 years ago
|
||
This just adds the user name we already supply to this factory - and that matches what we're doing for tags as well.
Attachment #492985 -
Flags: review?(bhearsum)
Comment 2•14 years ago
|
||
Comment on attachment 492985 [details] [diff] [review]
add the user name to this command
Feel free to land this at any time.
Attachment #492985 -
Flags: review?(bhearsum) → review+
Comment 3•14 years ago
|
||
(In reply to comment #1)
> Created attachment 492985 [details] [diff] [review]
> add the user name to this command
>
> This just adds the user name we already supply to this factory - and that
> matches what we're doing for tags as well.
Is this patch to 0.7, or 0.8 or does it apply to both?
Comment 4•14 years ago
|
||
It should apply to both cleanly.
Assignee | ||
Comment 5•14 years ago
|
||
Pushed to both branches:
http://hg.mozilla.org/build/buildbotcustom/rev/3a739d437e32 buildbot-0.7
http://hg.mozilla.org/build/buildbotcustom/rev/10f8a3a5d185 default
Ben do I need to enter this on any wiki page or does it just fly under the radar?
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 6•14 years ago
|
||
Please add it to the Maintenance page
Assignee | ||
Comment 7•14 years ago
|
||
OK, thanks, done.
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•