Closed Bug 614610 Opened 9 years ago Closed 9 years ago

content process crash reporting needs to add ProcessType=content annotation

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: ted, Assigned: benjamin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+jetpacks also
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #493701 - Flags: review?(ted.mielczarek)
blocking2.0: --- → final+
Comment on attachment 493701 [details] [diff] [review]
add ProcessType, rev. 1

>diff --git a/js/jetpack/JetpackParent.cpp b/js/jetpack/JetpackParent.cpp
>--- a/js/jetpack/JetpackParent.cpp
>+++ b/js/jetpack/JetpackParent.cpp
>@@ -301,19 +301,29 @@ JetpackParent::OnChannelConnected(int32 
>     NS_RUNTIMEABORT("can't open handle to child process");
> 
>   SetOtherProcess(handle);
> }
> 
> void
> JetpackParent::DispatchFailureMessage(const nsString& aDumpID)
> {
>-  KeyValue kv(NS_LITERAL_STRING("dumpID"), PrimVariant(aDumpID));
>+#ifdef MOZ_CRASHREPORTER
>+  CrashReporter::AnnotationTable notes;
>+  notes.Init();
>+  notes.Put(NS_LITERAL_CSTRING("ProcessType"), NS_LITERAL_CSTRING("jetpack"));
>+  // TODO: Additional per-process annotations.

Can you file a followup on this? For Jetpack processes, we're definitely going to want at least the extension ID and name. For content processes we probably don't have much extra useful info, especially since we only have one process. We should make sure the URL gets annotated at some point, maybe file a followup on that as well?
Attachment #493701 - Flags: review?(ted.mielczarek) → review+
Depends on: 615327
http://hg.mozilla.org/mozilla-central/rev/c0c537489cbf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 616131
Blocks: 616134
Filed bug 616131 for jetpack annotations, bug 616134 for content URL.
You need to log in before you can comment on or make changes to this bug.