Closed Bug 614733 Opened 9 years ago Closed 9 years ago

Do exponential backoff on background tab refresh drivers

Categories

(Core :: Layout, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files, 2 obsolete files)

roc suggested this earlier today.  Seems like an excellent idea to me.  David, any objections?
Attachment #493175 - Attachment is obsolete: true
Attachment #493176 - Flags: review?(dbaron)
Assignee: nobody → bzbarsky
What makes us start a repeating timer again when we go from throttled to unthrottled?  Maybe SetThrottled should stop and restart the timer (always) just like Notify does (when mThrottled)?

Other than that this looks fine, though.
> What makes us start a repeating timer again when we go from throttled to
> unthrottled? 

Nothing.  Good catch.

I'll fix it as you propose.
Actually, I'll just do that when going from throttled to not throttled.
Attachment #493176 - Attachment is obsolete: true
Attachment #493176 - Flags: review?(dbaron)
Actually, I just made it always stop/restart
Attachment #499860 - Flags: review?(dbaron)
Comment on attachment 499860 [details] [diff] [review]
Do exponential backoff on throttled refresh drivers.

r=dbaron
Attachment #499860 - Flags: review?(dbaron) → review+
Whiteboard: [need review] → [need gk2 ship]
http://hg.mozilla.org/projects/birch/rev/2e8d88ba3f7d
Whiteboard: [need gk2 ship] → fixed-in-birch
https://hg.mozilla.org/mozilla-central/rev/2e8d88ba3f7d
Status: NEW → RESOLVED
Closed: 9 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
Flags: in-testsuite?
Depends on: 667236
You need to log in before you can comment on or make changes to this bug.