614742 - Use HTML5 input types and validation

Status: VERIFIED FIXED

(support.mozilla.org :: Users and Groups, task, P4)

Description

[Paul Craciunoiu [:paulc]]

I was just reading about this [1], it would be nice to let Firefox validate email and required fields in user login and user registration. At least maybe we can use some of the bits in the blog post :)

http://blog.oldworld.fr/index.php?post/2010/11/17/HTML5-Forms-Validation-in-Firefox-4

Low pri.

Comment 1

[Paul Craciunoiu [:paulc]]

This is gonna be better if it waits for 2.4.1 ;)

We're going the way which involves subclassing forms and using the subclassed ones throughout.

Comment 2

[Paul Craciunoiu [:paulc]]

We actually turned back to monkey patching because the approach in comment 1 was too invasive and more verbose. Landed on master:
https://github.com/jsocol/kitsune/commit/d509153b34b28644212f4848d75b5dd68b86c807

For QA:
* Registration input for emails should be of type="email", both on /users/register and /questions/new in the last step (when asked to log in or register)
* The user profile view has URLs for Twitter, Facebook, and Website - these should be of type URL.
* The register form fields are in a different order now:
    Username
    Password
    Password again
    Email
* Required fields have a required attribute now.


All of this is best tested in Firefox 4 to see the client side validation :)

Let me know if you need help.

Comment 3

[Rebecca Billings [:rbillings]]

Verified all of the above. Asterisks are not yet visible, so checked 'required' attribute for fields.