614793 - Web console window should automatically scroll to display results

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Teodosia Pop]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101124 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101124 Firefox/4.0b8pre

When the scroll bar activates in web console, if entering a command, the window doesn't automatically scroll down so that the result can be visible.

Reproducible: Always

Steps to Reproduce:
1.Open the web console.
2.Type any commands until the scroll bar appears in the console.
3.Type any of commands: find(), typeof(), keys()
Actual Results:  
The web console window is not automatically scrolled vertically in order to see the result.

Expected Results:  
The web console window should automatically scroll to display the result.

This issue is also reproducible on Linux.

Comment 1

[Kevin Dangoor]

this should have been fixed with bug 601352, but it looks like you're running a nightly so you should have that fix.

Comment 2

[Mihai Sucan [:msucan]]

This is a regression that I noticed on Saturday while working on bug 613642, which looks like it's caused by some shuffling of console scrolling code - not sure which patch is to be blamed. Will fix ASAP.

Comment 3

[Mihai Sucan [:msucan]]

This now fixed by the patch in bug 613642, with a one line fix and a mochitest.

Comment 4

[Rob Campbell [:rc] (:robcee)]

it makes more sense to include your one line patch with test in this bug rather than bundling it with an unreviewed patch. We could get that reviewed more quickly this way.

Comment 5

[Mihai Sucan [:msucan]]

Attachment: proposed fix

Directly asking for review, because I already got f+ from Robert, for these changes. (in bug 613642)

The fix turned out to be three lines, not exactly a one-liner, but still, it's very small.

Comment 6

[Kevin Dangoor]

This should be blocking, because it's an annoying regression.

Comment 7

[Justin Dolske [:Dolske]]

I think this may have been fixed by bug 605621? I can't reproduce, and the relevant code seems to have been refactored.

Comment 8

[Mihai Sucan [:msucan]]

Correct. This bug is, indeed, fixed by the landing of part 1 patch from bug 605621.

Should I update the patch to only hold the mochitest? So we can have a test for this issue, in case of future regressions.

Comment 9

[Johnathan Nightingale [:johnath]]

(In reply to comment #8)
> Should I update the patch to only hold the mochitest? So we can have a test for
> this issue, in case of future regressions.

Indeed - and honestly, I'd say any peer review of the test is sufficient - wouldn't block on a formal review for a test-only patch. (Do make sure it passes on all platforms, though. :)

Comment 10

[Mihai Sucan [:msucan]]

Attachment: mochitest

Mochitest patch only.

Will send this through the tryserver, to make sure there are no failures.

Comment 11

[Mihai Sucan [:msucan]]

Try server results seem to be fine.

Comment 12

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 500847 [details] [diff] [review]
mochitest

wfm

Comment 13

[David Dahl :ddahl]

http://hg.mozilla.org/mozilla-central/rev/7cf8a9f5b7e2