614867 - Fix WebGL FBOs (pass framebuffer-object-attachment.html)

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: FBO changes

This patch makes us pass framebuffer-object-attachment.html.

The problem was that we were generating errors on mismatched FBO attachments (e.g. attaching a depth buffer to stencil attachment point), whereas the specs wanted us to only generate a framebuffer error on subsequent CheckFramebufferStatus / draw-calls.

Unfortunately, this required rather deep changes to be fool-proof. On a positive note, the new code seems more robust and natural to me.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 493301 [details] [diff] [review]
FBO changes

Looks good; I wonder if it's worth caching the bad attachments check so that it's not hit on every draw call?  Probably no need unless it becomes an issue.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

I was wondering the same; indeed, let's wait until draw-functions show up in profiles.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/63aebee31618