614937 - Make it possible to run have debug platforms with a corresponding opt one

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

I ran into this issue recently when SeaMonkey stopped producing opt/nightly builds for 32bit Mac, but wanted to still do debug ones to get debug testing on the 32bit/10.5 part of the builds. We currently depend on having an opt platform defined for every debug one just to get the base builder name for the "leak test build" column - it's easy to patch things for avoiding that when necessary.

Comment 1

[Robert Kaiser]

Attachment: support 'opt_base_name'

This is what I now have in use on the SeaMonkey master for this case. The patch allows the config to define an 'opt_base_name' and uses that if existing, else falls back to taking it from the opt config (as it does now).
With that, a debug platform without a corresponding opt one just needs to define this additional var and it works fine.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 493398 [details] [diff] [review]
support 'opt_base_name'

per IRC, not necessary.

Comment 3

[Robert Kaiser]

Comment on attachment 493398 [details] [diff] [review]
support 'opt_base_name'

I just found out that it _is_ necessary on 0.8 when you have enable_unittests on for debug and have no corresponding opt build. Firefox doesn't run into that because you run the tests on Talos, but we don't have and Talos machines, so we run the tests on the builders and that's where it hits us.

Comment 4

[Robert Kaiser]

Attachment: v1.1: updated to default branch

Actually, here's a version that applies cleanly to the default branch.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 497094 [details] [diff] [review]
v1.1: updated to default branch

Wrong patch, i think.

Comment 6

[Robert Kaiser]

(In reply to comment #5)
> Wrong patch, i think.

gah, sorry, real patch coming, attached the wrong file.

Comment 7

[Robert Kaiser]

Attachment: v1.1: updated to default branch, correct patch

Sorry again, here's the correct patch.

Comment 8

[Robert Kaiser]

Landed as http://hg.mozilla.org/build/buildbotcustom/rev/5bf01320a65a on default branch.