Closed Bug 614937 Opened 9 years ago Closed 9 years ago

Make it possible to run have debug platforms with a corresponding opt one

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Assigned: kairo)

Details

Attachments

(1 file, 2 obsolete files)

I ran into this issue recently when SeaMonkey stopped producing opt/nightly builds for 32bit Mac, but wanted to still do debug ones to get debug testing on the 32bit/10.5 part of the builds. We currently depend on having an opt platform defined for every debug one just to get the base builder name for the "leak test build" column - it's easy to patch things for avoiding that when necessary.
Attached patch support 'opt_base_name' (obsolete) — Splinter Review
This is what I now have in use on the SeaMonkey master for this case. The patch allows the config to define an 'opt_base_name' and uses that if existing, else falls back to taking it from the opt config (as it does now).
With that, a debug platform without a corresponding opt one just needs to define this additional var and it works fine.
Attachment #493398 - Flags: review?(bhearsum)
Comment on attachment 493398 [details] [diff] [review]
support 'opt_base_name'

per IRC, not necessary.
Attachment #493398 - Flags: review?(bhearsum)
Comment on attachment 493398 [details] [diff] [review]
support 'opt_base_name'

I just found out that it _is_ necessary on 0.8 when you have enable_unittests on for debug and have no corresponding opt build. Firefox doesn't run into that because you run the tests on Talos, but we don't have and Talos machines, so we run the tests on the builders and that's where it hits us.
Attachment #493398 - Flags: review?(bhearsum)
Attached patch v1.1: updated to default branch (obsolete) — Splinter Review
Actually, here's a version that applies cleanly to the default branch.
Attachment #493398 - Attachment is obsolete: true
Attachment #497094 - Flags: review?(bhearsum)
Attachment #493398 - Flags: review?(bhearsum)
Comment on attachment 497094 [details] [diff] [review]
v1.1: updated to default branch

Wrong patch, i think.
Attachment #497094 - Attachment is obsolete: true
Attachment #497094 - Flags: review?(bhearsum)
(In reply to comment #5)
> Wrong patch, i think.

gah, sorry, real patch coming, attached the wrong file.
Sorry again, here's the correct patch.
Attachment #497542 - Flags: review?(bhearsum)
Attachment #497542 - Flags: review?(bhearsum) → review+
Landed as http://hg.mozilla.org/build/buildbotcustom/rev/5bf01320a65a on default branch.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.