614988 - "ASSERTION: We should never try to use the editor if we're not initialized unless we're being initialized"

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: We should never try to use the editor if we're not initialized unless we're being initialized: 'mEditorInitialized || mInitializing', file content/html/content/src/nsTextEditorState.cpp, line 1717

This assertion was added in:
changeset:   a664aa828e62
user:        Ehsan Akhgari
date:        Mon Nov 22 03:12:56 2010 -0500
summary:     Bug 611189 - Parchment IF Reader Misbehaves; r=bzbarsky

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Hmm, this assertion doesn't apply to textarea's, but I forgot to exclude them in the original patch.  :(

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 493443 [details] [diff] [review]
Patch (v1)

How about just adding "!IsSingleLineTextControl() ||" to the start of the assert condition?

r=me either way, I guess.

Comment 4

[(no longer active)]

(In reply to comment #3)
> Comment on attachment 493443 [details] [diff] [review]
> Patch (v1)
> 
> How about just adding "!IsSingleLineTextControl() ||" to the start of the
> assert condition?

That would make it even less readable than it currently is...

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK, don't worry about it, then.  I guess I find a complex-ish conditional more readable than some ifdefs and ifs, but that may just be habit.  ;)

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b2dad520d4ae