615004 - Let Accesskey test check whether accesskey letter exists in the corresponding text

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Anas Husseini [:linostar]]

Let the Accesskey test check whether accesskey letter exists in the corresponding text. That will help detecting invalid accesskeys.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Axel, is that something we should do in Mozmill?

Comment 2

[[:Aleksej]]

It may not be always good to force accesskey letter to be present in the text.

The text may contain few characters convenient as an accesskey, e.g.
* if the text consists mostly of characters not quickly available with a standard keyboard layout, or
* if there is a very common accesskey for that operation not present in the text, or
* if all the usable characters are used already, or
* if there are multiple popular keyboard layouts, so the free characters might have different positions depending on the layout (which sometimes might lead to "Yes" and "No" being on the same physical key).

Comment 3

[Adrian Kalla [:adriank]]

* we would need to have a white-list of locales to run such a test on (if the tests will be executed automatically one day), as e.g. some Asian locales use English access keys for their localized labels, as they use English-keyboards

Beside that, I'm not sure if Mozmill is the right place for such a test, even if it should be quite easy to implement it. Tools operating on source files, like compare-locales, seem to be the better place for such checks in my opinion.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Those tools do not know to which element an access key is assigned to. Further the text/label is also unknown to them. Not sure how it could be done outside of a running browser instance.

Comment 5

[Axel Hecht [:Pike]]

Accesskey checks in the source are somewhat possible, 'cause we have pretty good heuristics on which key is an accesskey for which label, based on the name of the entities. Not perfect, but still.

As Adrian said, the test is rather useless for locales without keyboard support, so not sure if it's worth it. It's rather clear in the UI, too.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Which means we shouldn't spend time on it? Are you ok with a wontfix?

Comment 7

[Axel Hecht [:Pike]]

Yeah