615008 - Find alternative for platform.linux_distribution, which requires at least Python 2.6

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[[:Aleksej]]

Running with Python 2.5 can cause a crash, because "linux_distribution" was not available before Python 2.6: http://docs.python.org/library/platform.html?highlight=linux_distribution#platform.linux_distribution

INFO Passed: 2
INFO Failed: 2
INFO Skipped: 0
Traceback (most recent call last):
  File "/usr/bin/mozmill", line 8, in <module>
    load_entry_point('mozmill==1.5.1', 'console_scripts', 'mozmill')()
  File "/usr/lib/python2.5/site-packages/mozmill/__init__.py", line 811, in cli
    CLI().run()
  File "/usr/lib/python2.5/site-packages/mozmill/__init__.py", line 776, in run
    self.mozmill.report(self.options.report)
  File "/usr/lib/python2.5/site-packages/mozmill/__init__.py", line 473, in report
    results = self.get_report()
  File "/usr/lib/python2.5/site-packages/mozmill/__init__.py", line 418, in get_report
    report['system_info'] = self.get_platform_information()
  File "/usr/lib/python2.5/site-packages/mozmill/__init__.py", line 364, in get_platform_information
    (distro, version, codename) = platform.linux_distribution()
AttributeError: 'module' object has no attribute 'linux_distribution'

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

My fault when I have implemented bug 562822. We still support Python 2.5, and I have simply taken it over from Heather's template.

Comment 2

[cmtalbert]

I think this can be easily solved by changing platform.linux_distribution() to platform.dist(). Taking.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

As mentioned lets use the old but deprecated version. Should be fine at least until we support Python 3.

Comment 4

[Jeff Hammel]

Comment on attachment 495981 [details] [diff] [review]
Patch v1

Works for me here.  I haven't tested on all python versions.  For 2.0, I'd like to see this as part of the mozinfo package (bug 606524)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on hotfix-1.5.2 as:
https://github.com/mozautomation/mozmill/commit/e0f995a10150d64f78dfff937b59279bbc2ff5b4

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1 (mozmill-2.0)

> Works for me here.  I haven't tested on all python versions.  For 2.0, I'd like
> to see this as part of the mozinfo package (bug 606524)

There is a lot more stuff to do for a final implementation. This patch simply updates the code inside of info.py to make sure we do not fail.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on master:
https://github.com/mozautomation/mozmill/commit/4c155534445c306fa144d5e6e1b95b211a429b04

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Aleksej, could you please verify that it now works? We have pushed Mozmill 1.5.2 RC2 today to pypi, so a "pip install --upgrade mozmill" should update you to that version. Thanks.

Comment 9

[[:Aleksej]]

Verified fixed. Thanks.