615018 - Crash [@ nsCOMPtr_base::~nsCOMPtr_base() | PrefCallback::~PrefCallback()] on startup if no internet connection

Status: VERIFIED DUPLICATE of bug 614286

(Core :: Preferences: Backend, defect)

Description

[Joe Sabash [:JoeS1]]

Mozilla/5.0 (Windows NT 5.0; rv:2.0b8pre) Gecko/20101124 Thunderbird/3.3a2pre ID:20101124115027

Steps to reproduce:

Disconnect from the internet (pull your Lan cable or whatever)
Start TB (you get a failed connection popup)
Close TB and open it again ..crash

http://crash-stats.mozilla.com/report/index/549480a4-55cc-4f70-9301-5d8de2101126

At this point TB is completely unusable even after a system reboot, until an internet connection is establish.

Expected:
After the failed connection, we should be in offline mode.

This bug was not present at the time of 3.3 a1 release.

Comment 1

[rsx11m]

Reproducible for me on Windows 7 (x64) and Windows XP as well, however crashing with a different signature at the same location:

http://crash-stats.mozilla.com/report/index/461dd37e-b412-4e3a-ada8-51a532101126

That's nsRefPtr<nsTypedSelection>::~nsRefPtr<nsTypedSelection>() rather than nsCOMPtr_base::~nsCOMPtr_base() in Joe's crash report.

Comment 2

[rsx11m]

Here the crash reports for Windows 7, the signature depends on the build:

Build ID 20101123032806 crashed in nsRefPtr<nsTypedSelection>
http://crash-stats.mozilla.com/report/index/746e2747-afeb-411f-9192-1dd1e2101126

Build ID 20101126033241 crashes in nsCOMPtr_base
http://crash-stats.mozilla.com/report/index/984a2c9a-7551-4940-b3bc-be8912101126

Comment 3

[Ludovic Hirlimann [:Usul]]

stack : 

0 	xul.dll 	nsRefPtr<nsTypedSelection>::~nsRefPtr<nsTypedSelection> 	objdir-tb/mozilla/dist/include/nsAutoPtr.h:969
1 	xul.dll 	PrefCallback::~PrefCallback 	modules/libpref/src/nsPrefBranch.h:124
2 	xul.dll 	nsAutoPtr<PrefCallback>::~nsAutoPtr<PrefCallback> 	objdir-tb/mozilla/dist/include/nsAutoPtr.h:104
3 	xul.dll 	nsBaseHashtableET<PrefCallback,nsAutoPtr<PrefCallback> >::~nsBaseHashtableET<PrefCallback,nsAutoPtr<PrefCallback> > 	objdir-tb/mozilla/dist/include/nsBaseHashtable.h:330
4 	xul.dll 	PL_DHashTableRawRemove 	objdir-tb/mozilla/xpcom/build/pldhash.c:723
5 	xul.dll 	PL_DHashTableEnumerate 	objdir-tb/mozilla/xpcom/build/pldhash.c:757
6 	xul.dll 	nsBaseHashtable<PrefCallback,nsAutoPtr<PrefCallback>,PrefCallback*>::Enumerate 	objdir-tb/mozilla/dist/include/nsBaseHashtable.h:239
7 	xul.dll 	nsPrefBranch::freeObserverList 	modules/libpref/src/nsPrefBranch.cpp:760
8 	xul.dll 	nsPrefBranch::Observe 	modules/libpref/src/nsPrefBranch.cpp:707
9 	xul.dll 	nsObserverList::NotifyObservers 	xpcom/ds/nsObserverList.cpp:130
10 	xul.dll 	nsObserverService::NotifyObservers 	xpcom/ds/nsObserverService.cpp:182
11 	xul.dll 	mozilla::ShutdownXPCOM 	xpcom/build/nsXPComInit.cpp:631
12 	xul.dll 	ScopedXPCOMStartup::~ScopedXPCOMStartup 	toolkit/xre/nsAppRunner.cpp:1117
13 	xul.dll 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3457
14 	thunderbird.exe 	NS_internal_main



Gary can you find the regression on that one ?

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #3)
> Gary can you find the regression on that one ?

I can't reproduce this with any of the comm-central builds from 22-26 Nov nor 20 Nov, not with a fresh profile, nor with a profile with an IMAP account. :( Tried on Windows 7 64-bit.

Comment 5

[Ludovic Hirlimann [:Usul]]

Joe can you share the prefs that would be shown by about:support (ie the one you changed, maybe one is making the crash).

Comment 6

[rsx11m]

My comment #2 was based on a fresh profile, just using the Account Wizard to
set up a Gmail IMAP account. I connected once successfully, then shut down Thunderbird, unplugged the cable, restarted, and there was the crash. Nothing specific in that configuration.

Make sure to connect first successfully before unplugging the cable (I had initially problems reproducing on Windows XP when starting up with the LAN cable disconnected already without a prior connection in a session just before that) and that all network interfaces (wireless on a laptop?) are physically off and not just disabled.

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #6)
> My comment #2 was based on a fresh profile, just using the Account Wizard to
> set up a Gmail IMAP account. I connected once successfully, then shut down
> Thunderbird, unplugged the cable, restarted, and there was the crash. Nothing
> specific in that configuration.

Tried this too, no success either with 11/23 or 11/26 build.

> Make sure to connect first successfully before unplugging the cable (I had
> initially problems reproducing on Windows XP when starting up with the LAN
> cable disconnected already without a prior connection in a session just before
> that) and that all network interfaces (wireless on a laptop?) are physically
> off and not just disabled.

Yup, I unplugged my internet cable. :-/

Comment 8

[Joe Sabash [:JoeS1]]

(In reply to comment #5)
> Joe can you share the prefs that would be shown by about:support (ie the one
> you changed, maybe one is making the crash).

Nothing interesting there, I tested on my laptop with a min profile, just one pop3 account and some newsgroups. That was a zip build btw

Here is what I get for changed prefs:
extensions.lastAppVersion3.3a2pre
network.cookie.prefsMigratedtrue
places.history.expiration.transient_current_max_pages10714

I'm pretty sure I actually changed no prefs at all in that build.
The places pref strikes me as odd.
I'll try a build before places landed if I get a chance.

Comment 9

[Joe Sabash [:JoeS1]]

I'll tackle the regression range on this one but it's a real PIA connecting and
disconnecting...
20101122 still fails
I had a build from 20101103 and that works fine, detecting the offline condition immediately.
I'll bisect assuming 11-16 (Miramar works)good and 11-22 bad.

Comment 10

[Joe Sabash [:JoeS1]]

Regression range
20101117 works
20101118 crash

Comment 11

[rsx11m]

I've added the mozilla-central pushlog as URL for reference. In comm-central, only patches for SeaMonkey and Calendar were pushed at that time, and I wasn't running Lightning anywhere, thus those appear unlikely to be contributing.

Comment 12

[Ludovic Hirlimann [:Usul]]

I'm not seeing anything obvious here. Mark do you see something ?

Comment 13

[rsx11m]

There is a similar bug 614286 filed against Mac OSX, naming bug 580096 as the potential culprit. That patch was pushed on mozilla-central during a recent merge from tracemonkey, which would also match the regression range here:

http://hg.mozilla.org/mozilla-central/rev/b07a1861acf2
http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=78a42f77bb90

If we are lucky, the proposed fix for bug 614286 will fix the issue here as well (or this is actually a duplicate of the other one).

Comment 14

[rsx11m]

The current Windows tinderbox build does no longer crash for me with bug 614286 checked in this morning, thus I'd declare this fixed unless someone else still sees crashes specific to Thunderbird.

Comment 15

[rsx11m]

Joe and Nomis101, can you still reproduce the crash in today's nightly builds?

Comment 16

[Joe Sabash [:JoeS1]]

No crashes can be induced here
20101202 Thunderbird/3.3a2pre
Same system and method as the original bug filing.

Comment 17

[Joe Sabash [:JoeS1]]

It would be nice to get a mac user confirmation of the fix.
However I was able to reproduce the bug with a wireless DSL connection.
So duping to bug 614286

Comment 18

[Nomis101]

(In reply to comment #15)
> Joe and Nomis101, can you still reproduce the crash in today's nightly builds?

Thunderbird Trunk starts now without any problem if I have no internet connection on my Mac.