615034 - "ASSERTION: Element without owner document" with GC'd document

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Install 'DOM Fuzz Lite' from
    https://www.squarefree.com/extensions/domFuzzLite.xpi
2. Load the testcase.

###!!! ASSERTION: Element without owner document: 'Error', file content/base/src/nsGenericElement.cpp, line 3419

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yeah, this assert is semi-bogus while documents can go away before their elements.

Luckily, we're planning to fix that...

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Although I'm not sure whether we will actually force documents to live longer
than elements during unlink.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Sure, but that shouldn't be an issue for this testcase.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Jesse, this is fixed, right?

Comment 6

[Jesse Ruderman]

Yes.

Comment 7

[Martijn Wargers (dead)]

So should elements always have an ownerDocument then, ideally? Because I'm seeing currently a js error in one of my GreaseMonkey scripts that says that some element.ownerDocument is undefined.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

element.ownerDocument should always point to a valid document.
.ownerDocument is defined in nsIDOMNode, so if ownerDocument is undefined, it sounds like
element isn't actually element object but something else.