615058 - CC not threadsafe with DEBUG_CC on

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Robert Sayre]

###!!! ASSERTION: Didn't call FinishTraverse?: '!mCycleCollectionContext', file /Users/sayrer/dev/mozilla-central/js/src/xpconnect/src/nsXPConnect.cpp, line 460
Assertion failure: CURRENT_THREAD_IS_ME(t), at /Users/sayrer/dev/mozilla-central/js/src/jsapi.cpp:846

I'll have to check whether this happens in a normal debug build.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Yeah, I messed this up. The fix is in bug 565217. The CC is fine in normal debug builds, just not DEBUG_CC.

Comment 2

[Robert Sayre]

that patch crashes relatively quickly with this:

###!!! ABORT: count out of sync: 'mCompatObjects.Count() + mNormalObjects.Count() == mCount', file /Users/sayrer/dev/mozilla-central/xpcom/base/nsCycleCollector.cpp, line 903

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It seems pretty important to get DEBUG_CC working again so that we can debug leaks.  Can someone own this?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: stacks

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Sorry, way back when I put the fix in bug 565217. Since that didn't make FF4 I'll take this.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Comment 7

[Andreas Gal :gal]

bug 580096 broke this, pretty trivial fix

Comment 8

[Andreas Gal :gal]

Comment on attachment 511218 [details] [diff] [review]
Patch

NPOTB, lets take this

Comment 9

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/9f5cce1a629e

Comment 10

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/9f5cce1a629e