615074 - to + backing are unused ifndef JS_PUNBOX64 in FrameState::ensureFeSynced

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[timeless]

491 FrameState::ensureFeSynced(const FrameEntry *fe, Assembler &masm) const
492 {
493     Address to = addressOf(fe);
494     const FrameEntry *backing = fe;
495     if (fe->isCopy())
496         backing = fe->copyOf();
497 
498 #if defined JS_PUNBOX64
499     /* If we can, sync the type and data in one go. */
500     if (!fe->data.synced() && !fe->type.synced()) {
501         if (backing->isConstant())
502             masm.storeValue(backing->getValue(), to);
503         else if (backing->isTypeKnown())
504             masm.storeValueFromComponents(ImmType(backing->getKnownType()), backing->data.reg(), to);
505         else
506             masm.storeValueFromComponents(backing->type.reg(), backing->data.reg(), to);
507         return;
508     }
509 #endif
510 
511     /* 
512      * On x86_64, only one of the following two calls will have output,
513      * and a load will only occur if necessary.
514      */
515     ensureDataSynced(fe, masm);
516     ensureTypeSynced(fe, masm);
517 }

Comment 1

[timeless]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 493560 [details] [diff] [review]
patch

Please get approval before setting checkin-needed.

Comment 3

[timeless]

jwatt: i'm told that patches to tracemonkey code are generally just pushed into tracemonkey w/o approval requirements.

Comment 4

[Jonathan Watt [:jwatt]]

As discussed on IRC, it's not clear to me what the rules are, and if there are exceptions it would be good if someone would note those on:

https://wiki.mozilla.org/Tree_Rules

Also, if this patch is intended to go somewhere other than mozilla-central, please note that in the whiteboard so anyone grabbing extra checkin-needed patches knows where they should be pushing.

Comment 5

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/dadc1d60b6f3

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/dadc1d60b6f3