615081 - reddit-panel example uses jQuery, which is broken by platform regression

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The reddit-panel example addon uses jQuery in a content script, which is broken by platform regression bug 614757 in recent Firefox builds, including 4.0b7 and the tip.

Supporting the "JavaScript library in content script" use case, for which jQuery is a proxy, is critical to the web-accustomed users of the SDK, and we should not ship SDK 1.0 final without a good example of it, nor should Mozilla ship Firefox 4 without fixing that platform regression.

But it isn't absolutely necessary in order for us to ship the first SDK beta.  We can note it in the release notes and push hard to get it into a Firefox beta release as soon as possible (ideally, in 4.0b8, which is freezing very soon).

So we should pull jQuery from the reddit-panel example, replacing its usage with primitive DOM manipulation for the time being, and making plans to reintroduce it as soon as the platform regression is fixed.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: removes dependency on jQuery

This change removes the dependency on jQuery, replacing it with standard DOM APIs.

Also see pull request 54: https://github.com/mozilla/addon-sdk/pull/54

Comment 2

[Myk Melez [:myk] [@mykmelez]]

https://github.com/mozilla/addon-sdk/commit/6dfec0cf2fad7217fc37a007d39db7afc4b401cc