Closed Bug 615092 Opened 9 years ago Closed 9 years ago

Add a way to dump gfxASurfaces to a data url

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mattwoodrow, Assigned: roc)

Details

Attachments

(3 files, 2 obsolete files)

Attached patch First attempt (obsolete) — Splinter Review
Not sure if this should actually print to console, but its certainly easy to use from a debugger this way
Attachment #493554 - Attachment is patch: true
Attachment #493554 - Attachment mime type: application/octet-stream → text/plain
Attachment #493556 - Flags: review?(bas.schouten)
Attachment #493556 - Flags: review?(bas.schouten) → review+
I suggest you move the call to create the encoder down until you use the encoder. The encoder is sometimes not available (e.g. in plugin-container), and it's nice to still get to the part where we read the image data, because then you can at least read the data in the debugger.
Moved decoder initialization down.
Attachment #493554 - Attachment is obsolete: true
Attachment #493610 - Flags: review?(roc)
Fixed compile error, carrying forward r=Bas
Attachment #493556 - Attachment is obsolete: true
Attachment #493611 - Flags: review+
Attachment #493611 - Attachment is patch: true
Attachment #493611 - Attachment mime type: application/octet-stream → text/plain
Attached patch improved (?)Splinter Review
Attachment #493614 - Flags: review?(matt.woodrow+bugzilla)
Comment on attachment 493614 [details] [diff] [review]
improved (?)

Looks good, apart from the reftest.js debugging code that slipped in.
Attachment #493614 - Flags: review?(matt.woodrow+bugzilla) → review+
OS: Mac OS X → All
Comment on attachment 493614 [details] [diff] [review]
improved (?)

This is pretty insanely useful when dealing with surfaces for which there's no system tool available to visualize them.
Attachment #493614 - Flags: approval2.0?
Comment on attachment 493614 [details] [diff] [review]
improved (?)

not taking for Firefox 4. please hold until the trunk opens for post Firefox 4 changes.
Attachment #493614 - Flags: approval2.0? → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/e64ef5572e1b
Status: NEW → RESOLVED
Closed: 9 years ago
OS: All → Mac OS X
Resolution: --- → FIXED
Attachment #493610 - Flags: review?(roc)
Assignee: nobody → roc
You need to log in before you can comment on or make changes to this bug.