615092 - Add a way to dump gfxASurfaces to a data url

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: First attempt

Not sure if this should actually print to console, but its certainly easy to use from a debugger this way

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Add GetSize to gfxD2DSurface so DumpAsDataURL works

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I suggest you move the call to create the encoder down until you use the encoder. The encoder is sometimes not available (e.g. in plugin-container), and it's nice to still get to the part where we read the image data, because then you can at least read the data in the debugger.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Add DumpAsDataURL()

Moved decoder initialization down.

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Add GetSize to gfxD2DSurface so DumpAsDataURL works v2

Fixed compile error, carrying forward r=Bas

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: improved (?)

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 493614 [details] [diff] [review]
improved (?)

Looks good, apart from the reftest.js debugging code that slipped in.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 493614 [details] [diff] [review]
improved (?)

This is pretty insanely useful when dealing with surfaces for which there's no system tool available to visualize them.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 493614 [details] [diff] [review]
improved (?)

not taking for Firefox 4. please hold until the trunk opens for post Firefox 4 changes.

Comment 9

[Matt Woodrow (:mattwoodrow)]

http://hg.mozilla.org/mozilla-central/rev/e64ef5572e1b