615171 - Form assistant remains open even after loading another webpage

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anna (Waverley)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101119 Firefox/4.0b8pre
Build Identifier: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre) Gecko/20101128 Firefox/4.0b8pre Fennec /4.0b3pre

Form assistant and the option list from http://www.w3.org/MarkUp/Test/HTML401/current/tests/sec17_6_1-BF-01.html remain open even after loading another webpage.




Reproducible: Always

Steps to Reproduce:
1. Open Fennec and launch the page specified in the URL http://www.w3.org/MarkUp/Test/HTML401/current/tests/sec17_6_1-BF-01.html
2. Cashews is displayed in the drop down list as this is preselected option
3. Tap on the drop down (-> Form assistant should open and drop down / option list displayed)
5. Visit any webpage you want (e.g.: www.nytimes.com)
4. 

Actual Results:  
Form assistant and drop down / option list are still visible to the user. 

see the attached photo

Expected Results:  
Form assistant and drop down / option list should be dismissed.

Comment 1

[Anna (Waverley)]

Attachment: The Actual Result

Comment 2

[Tony Chung [:tchung]]

regression?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I can't seem to reproduce it on desktop, does it happen only on Android device?

Comment 4

[Anna (Waverley)]

I can't reproduce it anymore on Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre)Gecko/20101130 Firefox/4.0b8pre Fennec /4.0b3pre

Comment 5

[Aakash Desai [:aakashd]]

I can reproduce on build:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101130 Namoroka/4.0b8pre Fennec/4.0b3pre(Vibrant)


but NOT on build:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101130 Namoroka/4.0b8pre Fennec/4.0b3pre

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Mark, this is a regression of bug 609987. We need to ensure the assistant is closed before sending the "Show" message from the content to the chrome process.
The patch also add a few checks into findHelperUI and formHelperUI to prevent doing unuseful work during startup.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 494365 [details] [diff] [review]
Patch

Can we use a property for FindeHelperUI._open like we do for the FormHelperUI?

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser-ui.js#1987

>       case "Content:SetWindowSize":
>+        // We don't want to react to size change if he form assistant is not

// We don't want to react to size change if the form assistant is not

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's land this for beta 3

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/c0a9d11ef246

Thanks for the QA folks for catching this one, it was a really bad regression.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch - followup

shit!
I've completely messed up the repositioning of the view during a resize...
The followup patch resolve this bug and keep the repositioning working.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

followup push: http://hg.mozilla.org/mobile-browser/rev/c53531b5228b

Comment 12

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101203 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101203 Namoroka/4.0b8pre Fennec/4.0b3pre