All users were logged out of Bugzilla on October 13th, 2018

setting a clobber for 0.8.0 release builders causes them to show up in the main clobberer table

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: salbiz)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

I noticed this when setting a clobber for 3.6.13build2 this morning.
(Assignee)

Comment 1

8 years ago
Created attachment 493797 [details] [diff] [review]
update canSee to hide new release directories

We ran into this during staging runs, guess I must have forgotten to upload the fix.
Attachment #493797 - Flags: review?(bhearsum)
(Assignee)

Comment 2

8 years ago
Created attachment 494053 [details] [diff] [review]
use global RELEASE_PREFIX

figured out why this error was persisting. instead of using the globally defined RELEASE_PREFIX to identify releasedirs, the script was creating an empty $RELEASE_PREFIX inside the function. This slipped through testing since writing clobbers to the database fails silently.
Attachment #493797 - Attachment is obsolete: true
Attachment #494053 - Flags: review?(bhearsum)
Attachment #493797 - Flags: review?(bhearsum)
Comment on attachment 494053 [details] [diff] [review]
use global RELEASE_PREFIX

Sounds good to me, and works on staging.
Attachment #494053 - Flags: review?(bhearsum) → review+
Comment on attachment 494053 [details] [diff] [review]
use global RELEASE_PREFIX

changeset:   1333:eb445444f83c
Attachment #494053 - Flags: checked-in+
Looking good in production and staging now. Thanks Syed!
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Looks like instead of strstr we should use strpos or something similar (re match) here. $RELEASE_PREFIX should be at the beginning, not anywhere. strstr matches "release-whatever" and "whatever-release-blah", while strpos($builddir, $RELEASE_PREFIX)!=0 doesn't.

If we plan to shorten build directory path and use something like "r-" for the prefix, the possibility of false positive will be higher.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

8 years ago
Attachment #496013 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 9

8 years ago
Looks like this is finished.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.