615192 - setting a clobber for 0.8.0 release builders causes them to show up in the main clobberer table

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

I noticed this when setting a clobber for 3.6.13build2 this morning.

Comment 1

[Syed Albiz [:salbiz]]

Attachment: update canSee to hide new release directories

We ran into this during staging runs, guess I must have forgotten to upload the fix.

Comment 2

[Syed Albiz [:salbiz]]

Attachment: use global RELEASE_PREFIX

figured out why this error was persisting. instead of using the globally defined RELEASE_PREFIX to identify releasedirs, the script was creating an empty $RELEASE_PREFIX inside the function. This slipped through testing since writing clobbers to the database fails silently.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 494053 [details] [diff] [review]
use global RELEASE_PREFIX

Sounds good to me, and works on staging.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 494053 [details] [diff] [review]
use global RELEASE_PREFIX

changeset:   1333:eb445444f83c

Comment 5

[[e-mail] (:bhearsum)]

Looking good in production and staging now. Thanks Syed!

Comment 6

[Rail Aliiev [:rail]]

Looks like instead of strstr we should use strpos or something similar (re match) here. $RELEASE_PREFIX should be at the beginning, not anywhere. strstr matches "release-whatever" and "whatever-release-blah", while strpos($builddir, $RELEASE_PREFIX)!=0 doesn't.

If we plan to shorten build directory path and use something like "r-" for the prefix, the possibility of false positive will be higher.

Comment 7

[Rail Aliiev [:rail]]

Attachment: use strpos

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 496013 [details] [diff] [review]
use strpos

http://hg.mozilla.org/build/tools/rev/297106b653f2

Comment 9

[Syed Albiz [:salbiz]]

Looks like this is finished.