Created attachment 493672 [details] [diff] [review] Patch for eBay DE Search Plugin Per eBay's request, please update the search plugin to be included with Mozilla products per the attached patch. The changes add suggested search (not yet active) and cut the current number of redirects from the initial search query from 4 to 1. This change should block Fx4 for the DE locale.
Created attachment 493674 [details] [diff] [review] Patch for eBay DE Search Plugin Apologies, forgot to update the favicon as well, per eBay request.
Whiteboard: productization → [hardblocker]
Attachment #493674 - Flags: review?(stas) → review?(sethb)
Comment on attachment 493674 [details] [diff] [review] Patch for eBay DE Search Plugin This looks good. Thank you, Kev! As mentioned in the bug, can you please check this into your L10n-central repository, adding a comment that references bug 615200, this change, and r=sethb. Please test the new build and sign off. Once you have signed off, please resolve this bug again as fixed. Thanks to all.
Attachment #493674 - Flags: review?(sethb) → review+
Thanks, Kadir. After some nightly testing, can you sign off on this change and then resolve this bug as fixed? I appreciate the quick turnaround.
bot sure how to test, but ebay search works, so I guess this is done.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Can verify the icon update, no more brown color in the 'e'. Though I am getting 2 301 moved responses. [17:45:42.729] GET http://rover.ebay.com/rover/1/707-37276-17702-4/4?mpre=http://shop.ebay.de/?_nkw=desire [HTTP/1.1 301 Moved Permanently 297ms] [17:45:43.028] GET http://rover.ebay.de/rover/1/707-37276-17702-4/4?mpre=http%3A%2F%2Fshop.ebay.de%2F%3F_nkw%3Ddesire%26rvr_id%3D207339811434&cguid=f2db0f7812d0a0aa14e4d7e4ff800a4e [HTTP/1.1 301 Moved Permanently 391ms] Not something we have control over though. Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b11) Gecko/20100101 Firefox/4.0b11 DE locale
Status: RESOLVED → VERIFIED
Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the search service does not make use of the "type" attribute on Image elements. You should feel free to remove it.
You need to log in before you can comment on or make changes to this bug.