Update eBay DE Search Plugin

VERIFIED FIXED

Status

Mozilla Localizations
de / German
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: kev, Assigned: kev)

Tracking

({productization})

unspecified
productization

Firefox Tracking Flags

(blocking2.0 final+)

Details

(Whiteboard: [hardblocker][fx4-fixed-bugday])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 493672 [details] [diff] [review]
Patch for eBay DE Search Plugin

Per eBay's request, please update the search plugin to be included with Mozilla products per the attached patch. The changes add suggested search (not yet active) and cut the current number of redirects from the initial search query from 4 to 1. This change should block Fx4 for the DE locale.
Attachment #493672 - Flags: review?(stas)
(Assignee)

Updated

7 years ago
blocking2.0: --- → ?
(Assignee)

Comment 1

7 years ago
Created attachment 493674 [details] [diff] [review]
Patch for eBay DE Search Plugin

Apologies, forgot to update the favicon as well, per eBay request.
Attachment #493672 - Attachment is obsolete: true
Attachment #493674 - Flags: review?(stas)
Attachment #493672 - Flags: review?(stas)

Updated

7 years ago
blocking2.0: ? → final+

Updated

7 years ago
Assignee: nobody → kev

Updated

7 years ago
Keywords: productization
Whiteboard: productization → [hardblocker]
(Assignee)

Updated

7 years ago
Blocks: 625062
(Assignee)

Updated

7 years ago
Attachment #493674 - Flags: review?(stas) → review?(sethb)

Comment 2

7 years ago
Comment on attachment 493674 [details] [diff] [review]
Patch for eBay DE Search Plugin

This looks good.  Thank you, Kev!

As mentioned in the bug, can you please check this into your
L10n-central repository, adding a comment that references bug 615200, this change, and r=sethb.  

Please test the new build and sign off.  Once you have signed off, please resolve this bug again as fixed.

Thanks to all.
Attachment #493674 - Flags: review?(sethb) → review+

Comment 4

7 years ago
Thanks, Kadir.  After some nightly testing, can you sign off on this change and then resolve this bug as fixed?  I appreciate the quick turnaround.
bot sure how to test, but ebay search works, so I guess this is done.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 6

7 years ago
Can verify the icon update, no more brown color in the 'e'. Though I am getting 2 301 moved responses.

[17:45:42.729] GET http://rover.ebay.com/rover/1/707-37276-17702-4/4?mpre=http://shop.ebay.de/?_nkw=desire [HTTP/1.1 301 Moved Permanently 297ms]
[17:45:43.028] GET http://rover.ebay.de/rover/1/707-37276-17702-4/4?mpre=http%3A%2F%2Fshop.ebay.de%2F%3F_nkw%3Ddesire%26rvr_id%3D207339811434&cguid=f2db0f7812d0a0aa14e4d7e4ff800a4e [HTTP/1.1 301 Moved Permanently 391ms]

Not something we have control over though.

Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b11) Gecko/20100101 Firefox/4.0b11 DE locale
Status: RESOLVED → VERIFIED

Updated

7 years ago
Whiteboard: [hardblocker] → [hardblocker][fx4-fixed-bugday]
Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the search service does not make use of the "type" attribute on Image elements. You should feel free to remove it.
You need to log in before you can comment on or make changes to this bug.