615269 - IndexedDB: Cursors should not copy all results before iterating

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Patch attached, also makes |cursor.continue| not return a useless boolean.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 493723 [details] [diff] [review]
Patch, v1

Oops, this isn't quite ready yet.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2

Yay!

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Personally I would just do the simple thing though.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #3)
> Personally I would just do the simple thing though.

I'm hoping there was more to that comment than that ;)

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Sorry, comment 3 was meant for a different bug.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 494808 [details] [diff] [review]
Patch, v2

> IDBCursor::Continue(const jsval &aKey,
>+  if (key.IsUnset()) {
>+    key = mKey;
>+  }

The current key handling is very complicated. Rewrite to either of the solutions we talked about.

>+  else {
>+    switch (mDirection) {
>+      case nsIIDBCursor::NEXT:
>+      case nsIIDBCursor::NEXT_NO_DUPLICATE:
>+        if (key <= mKey) {
>+          return NS_ERROR_DOM_INDEXEDDB_DATA_ERR;
>+        }
>+        break;
> 
>+      case nsIIDBCursor::PREV:
>+      case nsIIDBCursor::PREV_NO_DUPLICATE:
>+        if (key >= mKey) {
>+          return NS_ERROR_DOM_INDEXEDDB_DATA_ERR;
>+        }
>+        break;
> 
>+      default:
>+        NS_NOTREACHED("Unknown direction type!");
>+    }


Simpler written as an if-statement.


Write tests for mutationgs.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Review fixes

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 496280 [details] [diff] [review]
Review fixes

r=me if you change mKey to only be used as the result of the query, not as the to-serach-for key.

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/50d960ec0809