Make webgl.verbose discoverable

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 493767 [details] [diff] [review]
patch

I know we've discussed this before, and you didn't want to make the code any more complicated than it was; but now I really think that we should do it.

This generates a JS warning once, when webgl.verbose=false and a WebGL warning happens, telling the user about that preference.

JS developers just expect JS warnings to show up in the error console, and they may well not know about the webgl preferences at all (since it's enabled by default).

I asked a few people and the ones who replied were in favor of such a change; I didn't get any reply in favor against such a change.
Attachment #493767 - Flags: review?(vladimir)
Comment on attachment 493767 [details] [diff] [review]
patch

Why would anyone argue against it?  There's no downside for them :-)  But, sure.
Attachment #493767 - Flags: review?(vladimir)
Attachment #493767 - Flags: review+
Attachment #493767 - Flags: approval2.0+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/51130bef63c6
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Assignee: nobody → bjacob
You need to log in before you can comment on or make changes to this bug.