615355 - Remove the assertion at the beginning of nsChromeRegistry::Init

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(no longer active)]

<http://mxr.mozilla.org/mozilla-central/source/chrome/src/nsChromeRegistry.cpp#184>

This assertion doesn't really assert what it advertizes (because GetIOService will initialize the IO service if it's not already initialized), and it changes the time we initialize the IO service in debug and non-debug builds (this is actually the call which triggers the service initialization in debug builds).

We should just remove this assertion, I think.

This is a follow-up from bug 614286 (see bug 614286 comment 25 for more info).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm.  So originally, this used to be an actual null-check, not an assert, because ill-behaved extensions could enter this code before the necko factory was even registered, which caused us to not be able to get the IOService here (because we simply didn't know how to).

Looks like this check was changed to an assert in bug 568691 part C.

Given that, I would be fine with removing the assert.

Comment 2

[(no longer active)]

I can write the patch before one can say Jack Robinson, but I'll wait for Benjamin to chime in first.

Comment 3

[Benjamin Smedberg]

r=me to remove the assert. We usually do get the IO service soon after that (processing the first chrome registration line), but I don't think there's a way for extensions to cause this kind of badness any more.

Comment 4

[(no longer active)]

Attachment: Patch (v1)

OK, then, I'm taking comment 3 as r+, and will proceed to ask for approval directly!  :-)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 494130 [details] [diff] [review]
Patch (v1)

a=me

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/98fa9c0cff7a