Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Moving Message Filter rule down beyond screen does not scroll / follow said rule

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
MailNews: General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Michael Lueck, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.1b3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b7pre) Gecko/20101008 Firefox/4.0b7pre SeaMonkey/2.1b1

I have a quite extensive set of Message Filter rules. I like to group the rules, and organize in alpha order. As such, I need to move new rules down into their proper spot when creating new rules. The SM UI in this screen does not follow selected new rule when it scrolls / is moved down past what rules are visible on the screen. Moving up/down beyond what is currently visible should cause an up/down scroll event to keep the Message Filter always visible.

Reproducible: Always

Steps to Reproduce:
1. Have a fairly extensive pre-existing Message Filter list, filling the screen
2. Move the top rule down beyond what rules are visible on the screen

Actual Results:  
Continue pushing down, it keeps going down but is out of site

Expected Results:  
When the filter rule reaches the bottom (or top going up) of the Filter Rule list, the scroll bar should auto-scroll to keep the in-focus Message Filter rule always visible.

Thunderbird 2.x UI works as expected. So this is a but specific to SM. I just migrated over from TB 2.x to SM.

Updated

7 years ago
Component: General → MailNews: General
QA Contact: general → mail
Version: unspecified → Trunk
(Reporter)

Comment 1

7 years ago
Problem persists / confirmed into b2 release: Mozilla/5.0 (X11; Linux i686; rv:2.0b11) Gecko/20110209 Firefox/4.0b11 SeaMonkey/2.1b2

Comment 2

7 years ago
Thunderbird Bug 461152 was fixed in TB 3.0.1 but was not fixed in SeaMonkey 2.0 despite the fixed-seamonkey2.0.3 flag there.

Comment 3

7 years ago
Jens, you've tested the filter dialog before haven't you? Do you see this on trunk builds?
(Assignee)

Comment 4

7 years ago
Confirming with trunk.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

7 years ago
OS: Linux → All
Hardware: x86 → All
(Assignee)

Comment 5

7 years ago
Created attachment 513155 [details] [diff] [review]
patch [Checkin: comment 9]

Unfortunately TB's code is quite different from ours here and I have little time, so I'm not assigning this to myself yet. If the simple solution I propose is not accepted, someone else will have to give it a try.
Attachment #513155 - Flags: review?(mnyromyr)

Comment 6

7 years ago
Comment on attachment 513155 [details] [diff] [review]
patch [Checkin: comment 9]

> +
> +    if (gFilterTree.view.selection.count > 0)
If we are moving a filter at least one has to be selected.

> +      document.getElementById("filterTree").treeBoxObject
gFilterTree.

> +              .ensureRowIsVisible(gFilterTree.currentIndex);
>  }
This works right? I haven't tested this yet.
Attachment #513155 - Flags: feedback-

Updated

7 years ago
Attachment #513155 - Flags: feedback-
(Assignee)

Comment 7

7 years ago
(In reply to comment #6)
> > +    if (gFilterTree.view.selection.count > 0)
> If we are moving a filter at least one has to be selected.
> 
> > +      document.getElementById("filterTree").treeBoxObject
> gFilterTree.

So true. I rushed it. Changed locally.

> > +              .ensureRowIsVisible(gFilterTree.currentIndex);
> >  }
> This works right? I haven't tested this yet.

I had a good moment and actually tried it before I uploaded it. :-P

Comment 8

7 years ago
Comment on attachment 513155 [details] [diff] [review]
patch [Checkin: comment 9]

r/moa=me with Ratty's nit fixed.
Attachment #513155 - Flags: superreview+
Attachment #513155 - Flags: review?(mnyromyr)
Attachment #513155 - Flags: review+
(Assignee)

Comment 9

7 years ago
Comment on attachment 513155 [details] [diff] [review]
patch [Checkin: comment 9]

http://hg.mozilla.org/comm-central/rev/c27f56222eaf
Nits address upon checkin.
Attachment #513155 - Attachment description: patch → patch [Checkin: comment 9]
(Assignee)

Updated

7 years ago
Assignee: nobody → jh
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
(Reporter)

Comment 10

6 years ago
Fix confirmed in SeaMonkey/2.1b3

Thank you!!! :-)
You need to log in before you can comment on or make changes to this bug.