615462 - Crash [@ gfxAlphaRecovery::RecoverAlpha]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

The crash happens more reliably in debug builds. When it doesn't crash, it can break painting instead.

bp-6f8713b6-59f5-498e-a20c-0bcd62101129

Comment 1

[Jesse Ruderman]

Attachment: crash report from a debug build

Comment 2

[Jesse Ruderman]

Windows-only, I think.

Comment 3

[Alex Miller]

(In reply to comment #2)
> Windows-only, I think.

I couldn't reproduce with an Ubuntu debug build

Comment 4

[Bas Schouten (:bas.schouten)]

This is because with Windows 7 with Direct2D this causes some alpha recovery to occur to draw a native theme background. I need to look into why because that's generally not a great idea.

In any case this performs native drawing on a 25933 by 24023. gfxASurface::CheckSurfaceSize will refuse this size because it will overflow. We therefor return a NULL surface but we don't actually check for that anywhere and we proceed to try and use it.

Comment 5

[Bas Schouten (:bas.schouten)]

Attachment: Only draw native theme for the dirty rect

This actually happens on all render modes for windows because of native theming. This patch should make us only draw the native theme for the dirty rect (which should be enough).

Comment 6

[Bas Schouten (:bas.schouten)]

Crashing is bad. We should get this fixed.

Comment 7

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/c46083e1b190