Closed Bug 615467 Opened 14 years ago Closed 13 years ago

intermittent failure in toolkit\mozapps\update\test\unit\test_0170_fileLocked_xp_win_complete.js | test failed (with xpcshell return code: 0), see following log: succeeded == failed

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Platform:
x86
Windows Server 2003
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla5

People

(Reporter: ehsan.akhgari, Assigned: robert.strong.bugs)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files, 2 obsolete files)

patch rev1 - give the helper process more time to start
9.55 KB, patch
mossop
: review+
Details | Diff | Splinter Review
patch - test cleanup
1.48 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291089585.1291091940.5092.gz&fulltext=1
WINNT 5.2 mozilla-central debug test xpcshell on 2010/11/29 19:59:45

TEST-INFO | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0170_fileLocked_xp_win_complete.js | running test ...
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0170_fileLocked_xp_win_complete.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>
### XPCOM_MEM_LEAK_LOG defined -- logging leaks to c:\docume~1\cltbld\locals~1\temp\tmpwndvfi\runxpcshelltests_leaks.log
pldhash: for the table at address 053FE278, the given entrySize of 48 probably favors chaining over double hashing.
TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-INFO | (xpcshell/head.js) | test 2 pending
TEST-INFO | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/mozapps/update/test/unit/head_update.js | [setupUpdaterTest : 1124] testing successful removal of the directory used to apply the mar file
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/mozapps/update/test/unit/head_update.js | [setupUpdaterTest : 1126] false == false
TEST-INFO | (xpcshell/head.js) | test 2 finished
TEST-INFO | (xpcshell/head.js) | running event loop
TEST-INFO | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/mozapps/update/test/unit/test_0170_fileLocked_xp_win_complete.js | [testUpdate : 85] testing updater binary process exitValue for success when applying a complete mar
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/mozapps/update/test/unit/test_0170_fileLocked_xp_win_complete.js | [testUpdate : 87] 0 == 0
TEST-INFO | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/mozapps/update/test/unit/test_0170_fileLocked_xp_win_complete.js | [testUpdate : 91] testing update.status should be failed
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/mozapps/update/test/unit/test_0170_fileLocked_xp_win_complete.js | succeeded == failed - See following stack:
JS frame :: e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\head.js :: do_throw :: line 424
JS frame :: e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\head.js :: do_check_eq :: line 476
JS frame :: e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/mozapps/update/test/unit/test_0170_fileLocked_xp_win_complete.js :: testUpdate :: line 94
JS frame :: e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\head.js :: <TOP_LEVEL> :: line 138
TEST-INFO | (xpcshell/head.js) | exiting test
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\head.js | exception thrown from do_timeout callback: 2147500036 - See following stack:
JS frame :: e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\head.js :: do_throw :: line 424
JS frame :: e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\head.js :: <TOP_LEVEL> :: line 140
TEST-INFO | (xpcshell/head.js) | exiting test
Unable to remove directory
path: e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\toolkit\mozapps\update\test\unit\0170_applyToDir
Exception: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/mozapps/update/test/unit/head_update.js :: removeDirRecursive :: line 903"  data: no]
nsNativeModuleLoader::LoadModule("e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\firefox\components\xpcomsample.dll") - load FAILED, rv: 80520012, error:
	<unknown; can't get error from NSPR>
WARNING: nsExceptionService ignoring thread destruction after shutdown: file e:/builds/moz2_slave/mozilla-central-win32-debug/build/xpcom/base/nsExceptionService.cpp, line 197
WARNING: OOPDeinit() without successful OOPInit(): file e:/builds/moz2_slave/mozilla-central-win32-debug/build/toolkit/crashreporter/nsExceptionHandler.cpp, line 1742
nsStringStats
 => mAllocCount:           1854
 => mReallocCount:           69
 => mFreeCount:            1854
 => mShareCount:           7133
 => mAdoptCount:            100
 => mAdoptFreeCount:        100
<<<<<<<
OS: Mac OS X → Windows Server 2003
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED

        Attachment #494158 -
        Flags: review?(dtownsend)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch - test cleanup (obsolete)
        — 
          — Splinter Review
      

    


  
The second patch contains mostly comment cleanup... I'm backporting a bunch of tests which I did some minor cleanup of and want the trunk tests to match with 1.9.2.

        Attachment #494159 -
        Flags: review?(dtownsend)

    
    

    
  
Comment on attachment 494159 [details] [diff] [review]
patch - test cleanup

hmmm... something strange going on here

        Attachment #494159 -
        Attachment is obsolete: true

        Attachment #494159 -
        Flags: review?(dtownsend)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        cleaup patch rev2 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #494162 -
        Flags: review?(dtownsend)

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

        Attachment #494158 -
        Flags: review?(dtownsend) → review+

    
    

    
  
Comment on attachment 494162 [details] [diff] [review]
cleaup patch rev2

I'll do the cleanup in a different bug

        Attachment #494162 -
        Attachment is obsolete: true

        Attachment #494162 -
        Flags: review?(dtownsend)

    
    

    
  
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/065c920fb372

I'm going to leave this open for a day or two to verify that it is actually fixed.

    
    

    
  
Resolving -> fixed. If this happens again please reopen or file a new bug. Thanks for the bug report... I hate oranges only slightly less than I hate causing them. :)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Flags: in-testsuite+
Flags: in-litmus-

    
    

    
      
  

    
    

    
  
Since every single instance has been on a debug build on the painfully slow Win2K3 VMs that are going to stop running tests soon, if there isn't anything else obvious, don't waste too much time chasing it, it'll probably go away when they do.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Seems to have gone away so resolving
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED

    
    

    
      
  

    
    

    
  
Meet the new slow, same as the old slow.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  


  
Showed this to Mossop in person and got a rs+ from him for it.

        Attachment #506843 -
        Flags: review+

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
I'm rewriting the tests in bug 386760 and believe it should fix this bug.
Depends on: 386760

    
    

    
  
bug 386760 made it so the tests can communicate with the test helper binary so this will hopefully no longer be a problem.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → FIXED

    
    

    
  
Bug 386760 was reopened.  :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Sure, it was reopened for the Mac nightly build failure which I landed a potential fix for (waiting on the build atm) but the tests that fixed this bug weren't backed out and are passing.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED

    
    

    
  
(In reply to comment #31)
> Sure, it was reopened for the Mac nightly build failure which I landed a
> potential fix for (waiting on the build atm) but the tests that fixed this bug
> weren't backed out and are passing.

You're right, sorry.
Target Milestone: mozilla2.0b8 → mozilla5

    
    

    
      
  

    
    

    
      
  
Whiteboard: [orange]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: