Geolocation prompt should ask the user a question

RESOLVED FIXED in Firefox 11

Status

()

Firefox
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: faaborg, Assigned: zpao)

Tracking

Trunk
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Currently the prompt contains the declarative statement:

site.domain.com wants to know your location.

As per the style guidelines for doorhangers, this needs to be a question, like:

Would you like to share your location with site.domain.com?
Assignee: nobody → paul
Whiteboard: [target-betaN]
Assuming we want this in Firefox 4, we'll want to block to make sure it gets [strings] attention.
blocking2.0: --- → ?
Whiteboard: [target-betaN] → [target-betaN][strings]
(Reporter)

Comment 2

6 years ago
Not a big enough issue to nominate, I was just getting it on file since I was reviewing all of the notifications for areweprettyyet
blocking2.0: ? → ---
(Reporter)

Updated

6 years ago
Whiteboard: [target-betaN][strings] → [target-betaN]
I was going through old bugs of mine and found this...

There are actually 2 strings here, one for file and one for site. Since not both were specified in comment 0, I'm following up...

Site:
"%S wants to know your location." --> "Would you like to share your location with %S?"

File:
"The file %S wants to know your location." --> ?

I'm thinking we make it "Would you like to share your location with the file %S?" but wanted somebody from UX to give a yes/no.

Sooooo Limi, Boriss, Faaborg (if you're still following along with bugmail at all)?
Created attachment 574950 [details] [diff] [review]
Patch v0.1

This is on the assumption that the file string I made is ok.
Attachment #574950 - Flags: review?(gavin.sharp)
Attachment #574950 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/integration/fx-team/rev/826bb288eb57
OS: Windows 7 → All
Whiteboard: [target-betaN] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/826bb288eb57
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.