Closed
Bug 615472
Opened 15 years ago
Closed 14 years ago
Geolocation prompt should ask the user a question
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: faaborg, Assigned: zpao)
Details
Attachments
(1 file)
2.62 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Currently the prompt contains the declarative statement:
site.domain.com wants to know your location.
As per the style guidelines for doorhangers, this needs to be a question, like:
Would you like to share your location with site.domain.com?
Updated•15 years ago
|
Assignee: nobody → paul
![]() |
||
Updated•15 years ago
|
Whiteboard: [target-betaN]
Assignee | ||
Comment 1•15 years ago
|
||
Assuming we want this in Firefox 4, we'll want to block to make sure it gets [strings] attention.
blocking2.0: --- → ?
Whiteboard: [target-betaN] → [target-betaN][strings]
Reporter | ||
Comment 2•15 years ago
|
||
Not a big enough issue to nominate, I was just getting it on file since I was reviewing all of the notifications for areweprettyyet
blocking2.0: ? → ---
Reporter | ||
Updated•15 years ago
|
Whiteboard: [target-betaN][strings] → [target-betaN]
Assignee | ||
Comment 3•14 years ago
|
||
I was going through old bugs of mine and found this...
There are actually 2 strings here, one for file and one for site. Since not both were specified in comment 0, I'm following up...
Site:
"%S wants to know your location." --> "Would you like to share your location with %S?"
File:
"The file %S wants to know your location." --> ?
I'm thinking we make it "Would you like to share your location with the file %S?" but wanted somebody from UX to give a yes/no.
Sooooo Limi, Boriss, Faaborg (if you're still following along with bugmail at all)?
Assignee | ||
Comment 4•14 years ago
|
||
This is on the assumption that the file string I made is ok.
Attachment #574950 -
Flags: review?(gavin.sharp)
Updated•14 years ago
|
Attachment #574950 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 5•14 years ago
|
||
OS: Windows 7 → All
Whiteboard: [target-betaN] → [fixed-in-fx-team]
![]() |
||
Comment 6•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•