615472 - Geolocation prompt should ask the user a question

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Currently the prompt contains the declarative statement:

site.domain.com wants to know your location.

As per the style guidelines for doorhangers, this needs to be a question, like:

Would you like to share your location with site.domain.com?

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Assuming we want this in Firefox 4, we'll want to block to make sure it gets [strings] attention.

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Not a big enough issue to nominate, I was just getting it on file since I was reviewing all of the notifications for areweprettyyet

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I was going through old bugs of mine and found this...

There are actually 2 strings here, one for file and one for site. Since not both were specified in comment 0, I'm following up...

Site:
"%S wants to know your location." --> "Would you like to share your location with %S?"

File:
"The file %S wants to know your location." --> ?

I'm thinking we make it "Would you like to share your location with the file %S?" but wanted somebody from UX to give a yes/no.

Sooooo Limi, Boriss, Faaborg (if you're still following along with bugmail at all)?

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

This is on the assumption that the file string I made is ok.

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

https://hg.mozilla.org/integration/fx-team/rev/826bb288eb57

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/826bb288eb57