615479 - Password manager prompts can now ask a more complete question

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Since we have more room in the new doorhanger notifications (relative to the notification bar), and since the full message can be derived quickly by simply reading the action button, I think we should consider expanding the question into a full sentence:

Would you like to remember the password for "username" on domain.com?
Would you like to update the password for "username"?

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Assuming we want this in Firefox 4, we'll want to block to make sure it gets
[strings] attention.

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

We don't need to block on this

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

I haven't actually run the tests here yet…

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 575219 [details] [diff] [review]
Patch v0.1

Review of attachment 575219 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
@@ +55,5 @@
>  rememberButtonText = &Remember
>  notifyBarRememberPasswordButtonText = Remember Password
>  notifyBarRememberPasswordButtonAccessKey = R
>  passwordChangeTitle = Confirm Password Change
>  # LOCALIZATION NOTE (updatePasswordText):

Known: I missed updating this l10n note

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

https://hg.mozilla.org/integration/fx-team/rev/e29db969d59e

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/e29db969d59e