Password manager prompts can now ask a more complete question

RESOLVED FIXED in mozilla11

Status

()

RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: faaborg, Assigned: zpao)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Since we have more room in the new doorhanger notifications (relative to the notification bar), and since the full message can be derived quickly by simply reading the action button, I think we should consider expanding the question into a full sentence:

Would you like to remember the password for "username" on domain.com?
Would you like to update the password for "username"?
Component: General → Password Manager
Product: Firefox → Toolkit
QA Contact: general → password.manager
Assignee: nobody → paul
Whiteboard: [target-betaN]
Assuming we want this in Firefox 4, we'll want to block to make sure it gets
[strings] attention.
blocking2.0: --- → ?
Whiteboard: [target-betaN] → [target-betaN][strings]
(Reporter)

Comment 2

8 years ago
We don't need to block on this
blocking2.0: ? → ---
Whiteboard: [target-betaN][strings] → [target-betaN]

Updated

8 years ago
Whiteboard: [target-betaN]
Version: unspecified → Trunk
Created attachment 575219 [details] [diff] [review]
Patch v0.1

I haven't actually run the tests here yet…
Attachment #575219 - Flags: review?(dolske)
Comment on attachment 575219 [details] [diff] [review]
Patch v0.1

Review of attachment 575219 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
@@ +55,5 @@
>  rememberButtonText = &Remember
>  notifyBarRememberPasswordButtonText = Remember Password
>  notifyBarRememberPasswordButtonAccessKey = R
>  passwordChangeTitle = Confirm Password Change
>  # LOCALIZATION NOTE (updatePasswordText):

Known: I missed updating this l10n note
Attachment #575219 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/e29db969d59e
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.