Closed
Bug 615479
Opened 14 years ago
Closed 13 years ago
Password manager prompts can now ask a more complete question
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: faaborg, Assigned: zpao)
Details
Attachments
(1 file)
9.81 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
Since we have more room in the new doorhanger notifications (relative to the notification bar), and since the full message can be derived quickly by simply reading the action button, I think we should consider expanding the question into a full sentence:
Would you like to remember the password for "username" on domain.com?
Would you like to update the password for "username"?
Updated•14 years ago
|
Component: General → Password Manager
Product: Firefox → Toolkit
QA Contact: general → password.manager
Updated•14 years ago
|
Assignee: nobody → paul
Updated•14 years ago
|
Whiteboard: [target-betaN]
Assignee | ||
Comment 1•14 years ago
|
||
Assuming we want this in Firefox 4, we'll want to block to make sure it gets
[strings] attention.
blocking2.0: --- → ?
Whiteboard: [target-betaN] → [target-betaN][strings]
Reporter | ||
Comment 2•14 years ago
|
||
We don't need to block on this
blocking2.0: ? → ---
Whiteboard: [target-betaN][strings] → [target-betaN]
Updated•13 years ago
|
Whiteboard: [target-betaN]
Version: unspecified → Trunk
Assignee | ||
Comment 3•13 years ago
|
||
I haven't actually run the tests here yet…
Attachment #575219 -
Flags: review?(dolske)
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 575219 [details] [diff] [review]
Patch v0.1
Review of attachment 575219 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
@@ +55,5 @@
> rememberButtonText = &Remember
> notifyBarRememberPasswordButtonText = Remember Password
> notifyBarRememberPasswordButtonAccessKey = R
> passwordChangeTitle = Confirm Password Change
> # LOCALIZATION NOTE (updatePasswordText):
Known: I missed updating this l10n note
Updated•13 years ago
|
Attachment #575219 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•