615515 - Dragged out items from Download manager to a FF tab have a blurry thumbnail

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Maniac Vlad Florin (:vladmaniac)]

Attachment: screenshot

Build ID:
Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101129 Firefox/4.0b8pre

Steps: 
1. Make sure you have some download history 
2. Bring up download manager 
3. Drag out an item onto a tab (this could be a doc file for e.g) 
4. Inspect UI of dragged item's thumbnail 

Behavior: 
Thumbnail appears blurry, the file name which is extracted from download manager looks abnormal (see screenshot). 

Note: 
This is reproducible also with the beta7 release candidate.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Is this a Regression against 3.6 or an earlier 4 Beta?
On WinXP this is not reproducible since i get no Image Preview at all...

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

I do not see the problem on 3.6

Comment 3

[juan becerra [:juanb]]

It regressed from 3.6 in the sense that now you are able to drag items out of the downloads window, and in Win 7 it looks ugly.

On XP using trunk you don't see the ugly text rendering as you drag the item over a tab. On Win 7 you can see the problem, at least all the way to Alpha 2, especially over a white background. It doesn't happen on 3.6.3 - 3.6.12 on XP because no thumbnail appears when you try to drag an item out of the downloads window.

Comment 4

[Dão Gottwald [:dao]]

Attachment: set the whole item as the drag image

Comment 5

[Neil Deakin]

Comment on attachment 494732 [details] [diff] [review]
set the whole item as the drag image

Using addElement instead of setDragImage would be more correct here.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 494732 [details] [diff] [review]
set the whole item as the drag image

I'll try that.

Comment 7

[Dão Gottwald [:dao]]

Attachment: set the whole item as the drag image, v2

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/23aa5649204e