gfx/ots/src/Makefile.in randomly clobbers VISIBILITY_FLAGS ifndef MOZ_ENABLE_LIBXUL instead of using config/system-headers

RESOLVED FIXED in mozilla2.0b8

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla2.0b8
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

567 bytes, patch
khuey
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
ld: warning: ots::OTSStream::Write(void const*, unsigned long)has different visibility (default) in ../../gfx/ots/src/libmozots.a(vdmx.o) and (hidden) in gfxUserFontSet.o
[lots of these]

ld: warning: unsigned long const& std::min<unsigned long>(unsigned long const&, unsigned long const&)has different visibility (default) in ../../gfx/ots/src/libmozots.a(ots.o) and (hidden) in gfxUserFontSet.o
[a handful of these]

this crude patch "fixed" the above warnings:
diff --git a/gfx/ots/include/opentype-sanitiser.h b/gfx/ots/include/opentype-sanitiser.h
--- a/gfx/ots/include/opentype-sanitiser.h
+++ b/gfx/ots/include/opentype-sanitiser.h
@@ -7,2 +7,4 @@
 
+#pragma GCC visibility push(default)
+
 #if defined(_MSC_VER)

@@ -185,2 +190,4 @@ void DisableDebugOutput();
 
+#pragma GCC visibility pop
+
 #endif  // OPENTYPE_SANITISER_H_

I'll post the more correct patch to config/system-headers after i get off battery power and can verify it works
(Assignee)

Comment 2

8 years ago
ok, glandium figured this out, it happens ifndef MOZ_ENABLE_LIBXUL, because of a random block in the Makefile.
Summary: opentype-sanitiser.h needs to be added to config/system-headers → gfx/ots/src/Makefile.in randomly clobbers VISIBILITY_FLAGS ifndef MOZ_ENABLE_LIBXUL
(Assignee)

Updated

8 years ago
Summary: gfx/ots/src/Makefile.in randomly clobbers VISIBILITY_FLAGS ifndef MOZ_ENABLE_LIBXUL → gfx/ots/src/Makefile.in randomly clobbers VISIBILITY_FLAGS ifndef MOZ_ENABLE_LIBXUL instead of using config/system-headers
(Assignee)

Comment 3

8 years ago
Created attachment 494062 [details] [diff] [review]
this fixes disable-libxul
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #494062 - Flags: review?(khuey)
Attachment #494062 - Flags: feedback?(mh+mozilla)
Comment on attachment 494062 [details] [diff] [review]
this fixes disable-libxul

Well, apparently the system wrapper is not even necessary.
Attachment #494062 - Flags: feedback?(mh+mozilla) → feedback-
(Assignee)

Comment 5

8 years ago
Created attachment 494973 [details] [diff] [review]
patch
Attachment #494062 - Attachment is obsolete: true
Attachment #494973 - Flags: review?(khuey)
Attachment #494973 - Flags: approval2.0?
Attachment #494973 - Flags: approval2.0? → approval2.0+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/56dd675c96f3
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.