Closed
Bug 615559
Opened 15 years ago
Closed 15 years ago
Buildbot waterfall limited to category=release shows unittest builders for mozilla-central
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: dustin)
References
Details
(Whiteboard: [automation])
Attachments
(2 files)
|
2.20 KB,
patch
|
bhearsum
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
|
4.35 KB,
patch
|
catlee
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
If you load waterfall?num_events=50&category=release page, you can see unittest builders for mozilla-central. Looks like generateTestBuilder returns the builders with wrongly set category.
|
Reporter | |
Comment 2•15 years ago
|
||
Seems like changing only category for builders is not reconfig safe.
|
Assignee | |
Comment 3•15 years ago
|
||
Assignee: nobody → dustin
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #494321 -
Flags: review?(bhearsum)
|
||
Comment 5•15 years ago
|
||
Comment on attachment 494321 [details] [diff] [review]
6fb3600cf7d.patch
*stamp*
Attachment #494321 -
Flags: review?(bhearsum) → review+
|
|
||
Comment 6•15 years ago
|
||
I think this is ready to land in the next tree closure window.
Flags: needs-treeclosure?
|
|
Reporter | |
Comment 7•15 years ago
|
||
Additionally there is another place should be adjusted. generateTestBuilder assumes category=branch_name. We should pass the category to prevent this. See attached patch.
Attachment #495498 -
Flags: review?(catlee)
|
|
Reporter | |
Comment 8•15 years ago
|
||
Comment on attachment 495498 [details] [diff] [review]
Fix generateTestBuilder
Just tested it in staging. I can see the unittests in category=release-mozilla-central- and nothing in category=release
|
||
Updated•15 years ago
|
Attachment #495498 -
Flags: review?(catlee) → review+
|
|
||
Comment 9•15 years ago
|
||
Comment on attachment 495498 [details] [diff] [review]
Fix generateTestBuilder
changeset: 1252:28c7a427734b
Landed on the default branch, will be merged into production and on the Buildbot masters tomorrow morning.
Attachment #495498 -
Flags: checked-in+
|
|
||
Comment 10•15 years ago
|
||
Comment on attachment 494321 [details] [diff] [review]
6fb3600cf7d.patch
changeset: 112:c901b723778d
Landed on the default branch, will be merged into production and on the Buildbot masters tomorrow morning.
Attachment #494321 -
Flags: checked-in+
|
|
||
Comment 11•15 years ago
|
||
Will be landing this in a rolling downtime tomorrow -- aka no tree closure needed....needs-reconfig+ is the best analogue.
Flags: needs-treeclosure? → needs-reconfig+
|
|
||
Comment 12•15 years ago
|
||
Should be all done here now.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•